public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM5858] Search Object - Searching no longer non-casesensitive
Date: Wed, 14 Oct 2020 17:20:02 +0530
Message-ID: <CAM9w-_mdo0n3pFuO9LoFJQCPkocL1X9=YicTwYiDuyZMNo9tGw@mail.gmail.com> (raw)
Hi Hackers,
The attached patch will make search objects searching case insensitive.
Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM5858.patch (1.2K, 3-RM5858.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/search_objects/utils.py b/web/pgadmin/tools/search_objects/utils.py
index a56e1322f..1f4dde1ab 100644
--- a/web/pgadmin/tools/search_objects/utils.py
+++ b/web/pgadmin/tools/search_objects/utils.py
@@ -88,12 +88,6 @@ class SearchObjectsHelper:
**kwargs
)
- def finalize_id_path(self, path, base_path):
- if base_path is not None:
- path = '{0}/{1}'.format(base_path, path)
-
- return path
-
def search(self, text, obj_type=None):
conn = self.manager.connection(did=self.did)
last_system_oid = (self.manager.db_info[self.did])['datlastsysoid'] \
@@ -110,7 +104,8 @@ class SearchObjectsHelper:
# D - Catalog schema with DB support - pg_catalog
# O - Catalog schema with object support only - info schema, dbo, sys
status, res = conn.execute_dict(
- self.get_sql('search.sql', search_text=text, obj_type=obj_type,
+ self.get_sql('search.sql',
+ search_text=text.lower(), obj_type=obj_type,
show_system_objects=self.show_system_objects,
show_node_prefs=show_node_prefs, _=gettext,
last_system_oid=last_system_oid)
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin][RM5858] Search Object - Searching no longer non-casesensitive
In-Reply-To: <CAM9w-_mdo0n3pFuO9LoFJQCPkocL1X9=YicTwYiDuyZMNo9tGw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox