public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM5858] Search Object - Searching no longer non-casesensitive
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM5858] Search Object - Searching no longer non-casesensitive
@ 2020-10-14 11:50 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Toshniwal @ 2020-10-14 11:50 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
The attached patch will make search objects searching case insensitive.
Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM5858.patch (1.2K, 3-RM5858.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/search_objects/utils.py b/web/pgadmin/tools/search_objects/utils.py
index a56e1322f..1f4dde1ab 100644
--- a/web/pgadmin/tools/search_objects/utils.py
+++ b/web/pgadmin/tools/search_objects/utils.py
@@ -88,12 +88,6 @@ class SearchObjectsHelper:
**kwargs
)
- def finalize_id_path(self, path, base_path):
- if base_path is not None:
- path = '{0}/{1}'.format(base_path, path)
-
- return path
-
def search(self, text, obj_type=None):
conn = self.manager.connection(did=self.did)
last_system_oid = (self.manager.db_info[self.did])['datlastsysoid'] \
@@ -110,7 +104,8 @@ class SearchObjectsHelper:
# D - Catalog schema with DB support - pg_catalog
# O - Catalog schema with object support only - info schema, dbo, sys
status, res = conn.execute_dict(
- self.get_sql('search.sql', search_text=text, obj_type=obj_type,
+ self.get_sql('search.sql',
+ search_text=text.lower(), obj_type=obj_type,
show_system_objects=self.show_system_objects,
show_node_prefs=show_node_prefs, _=gettext,
last_system_oid=last_system_oid)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM5858] Search Object - Searching no longer non-casesensitive
@ 2020-10-15 10:50 Akshay Joshi <[email protected]>
parent: Aditya Toshniwal <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2020-10-15 10:50 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Wed, Oct 14, 2020 at 5:20 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> The attached patch will make search objects searching case insensitive.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-10-15 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 11:50 [pgAdmin][RM5858] Search Object - Searching no longer non-casesensitive Aditya Toshniwal <[email protected]>
2020-10-15 10:50 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox