public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM4220] Users Dialog doesn't scroll
Date: Thu, 5 Dec 2019 15:30:00 +0530
Message-ID: <CAM9w-_n9AYVH1RHguX2vFinpQh_aunBpYt0684qzwko4wDJDmw@mail.gmail.com> (raw)

Hi Hackers,

Attached is the patch to fix the scrolling issue in "Users" dialog.
I tested on Chrome, Safari, Firefox and IE. Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM4220.patch (2.2K, 3-RM4220.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/user_management/static/js/user_management.js b/web/pgadmin/tools/user_management/static/js/user_management.js
index ea65ca7ac..b1156bf4f 100644
--- a/web/pgadmin/tools/user_management/static/js/user_management.js
+++ b/web/pgadmin/tools/user_management/static/js/user_management.js
@@ -777,7 +777,7 @@ define([
                   add_title: gettext('Add new user'),
                 },
                 $gridBody = $('<div></div>', {
-                  class: 'user_container',
+                  class: 'user_container flex-grow-1',
                 });
 
               $.ajax({
@@ -801,12 +801,12 @@ define([
                 row: UserRow,
                 columns: gridSchema.columns,
                 collection: userCollection,
-                className: 'backgrid table table-bordered table-noouter-border table-hover',
+                className: 'backgrid table table-bordered table-noouter-border table-bottom-border table-hover',
               });
 
               $gridBody.append(view.render().$el[0]);
 
-              this.$content = $('<div class=\'user_management object subnode subnode-noouter-border\'></div>').append(
+              this.$content = $('<div class=\'user_management object subnode subnode-noouter-border d-flex flex-column\'></div>').append(
                 headerTpl(data)).append($gridBody).append($statusBar);
 
               this.elements.content.appendChild(this.$content[0]);
diff --git a/web/pgadmin/tools/user_management/static/scss/_user_management.scss b/web/pgadmin/tools/user_management/static/scss/_user_management.scss
index ca1b090a2..c45ea9bac 100644
--- a/web/pgadmin/tools/user_management/static/scss/_user_management.scss
+++ b/web/pgadmin/tools/user_management/static/scss/_user_management.scss
@@ -4,11 +4,19 @@
 
 .user_container {
   border-bottom: $panel-border;
+  height: 100%;
+  min-height: 0;
+  margin-top: $title-height;
 }
 
 .user_management {
   height: 100%;
   overflow: hidden;
+
+  & .navtab-inline-controls {
+    position: absolute;
+    width: 100%;
+  }
 }
 
 .user_management .search_users form {
@@ -24,4 +32,4 @@
 
 .user_management .backform-tab {
   height: calc(100% - 75px);
-}
\ No newline at end of file
+}

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM4220] Users Dialog doesn't scroll
  In-Reply-To: <CAM9w-_n9AYVH1RHguX2vFinpQh_aunBpYt0684qzwko4wDJDmw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox