public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM4220] Users Dialog doesn't scroll
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM4220] Users Dialog doesn't scroll
@ 2019-12-05 10:00 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Toshniwal @ 2019-12-05 10:00 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch to fix the scrolling issue in "Users" dialog.
I tested on Chrome, Safari, Firefox and IE. Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM4220.patch (2.2K, 3-RM4220.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/user_management/static/js/user_management.js b/web/pgadmin/tools/user_management/static/js/user_management.js
index ea65ca7ac..b1156bf4f 100644
--- a/web/pgadmin/tools/user_management/static/js/user_management.js
+++ b/web/pgadmin/tools/user_management/static/js/user_management.js
@@ -777,7 +777,7 @@ define([
add_title: gettext('Add new user'),
},
$gridBody = $('<div></div>', {
- class: 'user_container',
+ class: 'user_container flex-grow-1',
});
$.ajax({
@@ -801,12 +801,12 @@ define([
row: UserRow,
columns: gridSchema.columns,
collection: userCollection,
- className: 'backgrid table table-bordered table-noouter-border table-hover',
+ className: 'backgrid table table-bordered table-noouter-border table-bottom-border table-hover',
});
$gridBody.append(view.render().$el[0]);
- this.$content = $('<div class=\'user_management object subnode subnode-noouter-border\'></div>').append(
+ this.$content = $('<div class=\'user_management object subnode subnode-noouter-border d-flex flex-column\'></div>').append(
headerTpl(data)).append($gridBody).append($statusBar);
this.elements.content.appendChild(this.$content[0]);
diff --git a/web/pgadmin/tools/user_management/static/scss/_user_management.scss b/web/pgadmin/tools/user_management/static/scss/_user_management.scss
index ca1b090a2..c45ea9bac 100644
--- a/web/pgadmin/tools/user_management/static/scss/_user_management.scss
+++ b/web/pgadmin/tools/user_management/static/scss/_user_management.scss
@@ -4,11 +4,19 @@
.user_container {
border-bottom: $panel-border;
+ height: 100%;
+ min-height: 0;
+ margin-top: $title-height;
}
.user_management {
height: 100%;
overflow: hidden;
+
+ & .navtab-inline-controls {
+ position: absolute;
+ width: 100%;
+ }
}
.user_management .search_users form {
@@ -24,4 +32,4 @@
.user_management .backform-tab {
height: calc(100% - 75px);
-}
\ No newline at end of file
+}
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM4220] Users Dialog doesn't scroll
@ 2019-12-05 12:21 Akshay Joshi <[email protected]>
parent: Aditya Toshniwal <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2019-12-05 12:21 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Thu, Dec 5, 2019 at 3:30 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the scrolling issue in "Users" dialog.
> I tested on Chrome, Safari, Firefox and IE. Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-12-05 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 10:00 [pgAdmin][RM4220] Users Dialog doesn't scroll Aditya Toshniwal <[email protected]>
2019-12-05 12:21 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox