public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: khushboo.vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Remove hacky way to open/close the dropdown-submenu
Date: Thu, 31 Jan 2019 14:38:04 +0530
Message-ID: <CAM9w-_nVX4igQiS54VYxGvT-N+eGY0QtxY3b5fW_5CYk6FW5Tg@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmozihuG=Vsn0s_P5wqtZtrB-SjsafFF4NuYiCz=KvADebA@mail.gmail.com>
References: <CAG7mmoy_yxF8V842aPYKKzpT4+JEikFwhai8MpQXw_ABqSfp0g@mail.gmail.com>
<CAG7mmoz4zg5o0JDCPEVjAi9hCsCVFTuNuvaWDNx+jB9CyT+Gdw@mail.gmail.com>
<CAM9w-_n0JOZ4nCFPVUput8XX41f6CwG7eUuBLxtSP0Rsa8-AXw@mail.gmail.com>
<CAG7mmozihuG=Vsn0s_P5wqtZtrB-SjsafFF4NuYiCz=KvADebA@mail.gmail.com>
Hi Ashesh,
All works good, except one small change. Submenus should be closed if I
press Esc and then reopen the menu.
On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi <[email protected]>
wrote:
> Hi Aditya,
>
> On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Ashesh,
>>
>> I am getting a syntax error on bundle.
>> After fixing that, please look into this scenario:
>> Using keyboard shortcuts open object menu, for eg on table node. Go to
>> any submenu using keyboard and go to any submenu and press enter.
>> Now open object menu again using keyboard shortcut, the submenu remains
>> open. It should be closed.
>>
> Please find the updated patch with all comments fixed.
> Now - whenever the callback for the menu is called (menu toggling), it
> will close the existing submenu(s) too.
>
> Please review it, and let me know.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/;
>
>
> *http://www.linkedin.com/in/asheshvashi
> <http://www.linkedin.com/in/asheshvashi>*
>
>
>>
>> Everything looks fine to me except the above.
>>
>>
>> On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> Any update?
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com;
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi;
>>>
>>>
>>> On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi Aditya/Khushboo,
>>>>
>>>> I can see a hacky way to open/close the dropdown-submenu in the menu.js
>>>> file.
>>>> I've followed a more general way to open/close any submenu in the
>>>> dropdown list, instead of just 'Objects' menu.
>>>>
>>>> Can you please review it, and let me know your thoughts?
>>>> Let me know if you have any other better approach.
>>>>
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com;
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Remove hacky way to open/close the dropdown-submenu
In-Reply-To: <CAM9w-_nVX4igQiS54VYxGvT-N+eGY0QtxY3b5fW_5CYk6FW5Tg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox