public inbox for [email protected]  

help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it
Date: Thu, 30 May 2019 16:05:46 +0530
Message-ID: <CAM9w-_nb7_qEty4tKpp756OdtsE2izrqx8GMFksmCFpWE4cL7w@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQSK1LWucitTb8QwOuV3JW0kf8d66UgXg_iC2Ob+OiJjA@mail.gmail.com>
References: <CAKKotZQSK1LWucitTb8QwOuV3JW0kf8d66UgXg_iC2Ob+OiJjA@mail.gmail.com>

Hi Murtuza,

I was just going through code change, and I would suggest one small change.
In the image_mapper.js, export it as default, as it will have only one
export. Then you can use it as imageMapper.default rather than imageMapper.
imageMapper.
Otherwise, looks fine to me. I didn't test though :P


On Thu, May 30, 2019 at 2:41 PM Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> Embedding images using *.toDataURL()* method hits the performance of the
> explain plan rendering if the plan is complex because first it downloads
> the images then it will convert each images into base64, to improve the
> performance we will embed the images only when downloading of SVG is called
> and not when displaying the graphical plan.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


view thread (4+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it
  In-Reply-To: <CAM9w-_nb7_qEty4tKpp756OdtsE2izrqx8GMFksmCFpWE4cL7w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox