public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it
Date: Thu, 30 May 2019 17:57:51 +0530
Message-ID: <CANxoLDcje7w+poMi4mDJ=4WEF71mFJg8xfMJeb9FrtbaqkA29A@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQT05QY6hanZMG_7_g5_QrJ5FTwYx9MgOrxnQ7cH+znZw@mail.gmail.com>
References: <CAKKotZQSK1LWucitTb8QwOuV3JW0kf8d66UgXg_iC2Ob+OiJjA@mail.gmail.com>
	<CAM9w-_nb7_qEty4tKpp756OdtsE2izrqx8GMFksmCFpWE4cL7w@mail.gmail.com>
	<CAKKotZQT05QY6hanZMG_7_g5_QrJ5FTwYx9MgOrxnQ7cH+znZw@mail.gmail.com>

Thanks patch applied.

On Thu, May 30, 2019 at 5:01 PM Murtuza Zabuawala <
[email protected]> wrote:

> Here is updated patch.
>
> On Thu, May 30, 2019 at 4:06 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Murtuza,
>>
>> I was just going through code change, and I would suggest one small
>> change.
>> In the image_mapper.js, export it as default, as it will have only one
>> export. Then you can use it as imageMapper.default rather than
>> imageMapper.imageMapper.
>> Otherwise, looks fine to me. I didn't test though :P
>>
>>
>> On Thu, May 30, 2019 at 2:41 PM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Embedding images using *.toDataURL()* method hits the performance of
>>> the explain plan rendering if the plan is complex because first it
>>> downloads the images then it will convert each images into base64, to
>>> improve the performance we will embed the images only when downloading of
>>> SVG is called and not when displaying the graphical plan.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


view thread (4+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explain plan only when user try to download it
  In-Reply-To: <CANxoLDcje7w+poMi4mDJ=4WEF71mFJg8xfMJeb9FrtbaqkA29A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox