public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs
Date: Wed, 19 Jun 2019 12:34:58 +0530
Message-ID: <CAM9w-_nubB2oCc-1SsVq_3t1m5akVO0-HxxwNgygsr7ST+Jtog@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxWguUfX6+Xg+jPgpDMBZYOxC65zjMbSEP1-8LhshwSQA@mail.gmail.com>
References: <CAM9w-_m2nNvKEQPGiHEtFCNF4Qg1aZ0MeTqB=6zNpMe5zj8rUg@mail.gmail.com>
<CANxoLDd7ERSsT2YxHpoLR8WL-Dz0E8HF0RpcxaT_KCFSpgoc_A@mail.gmail.com>
<CAM9w-_mkawLvUPZP0Y+KRbJ=5NoRKou67PG9UESdQYtktKEzbQ@mail.gmail.com>
<CA+OCxow_qE-DiSYrs482VBKaC5JKnvGNvAiL-mXy2VHH5eT5Cg@mail.gmail.com>
<CAM9w-_=5S=zxwy+bFEN2V9AOLyiYMMmTdh1S6+sFccE4zV6xPw@mail.gmail.com>
<CA+OCxoxWguUfX6+Xg+jPgpDMBZYOxC65zjMbSEP1-8LhshwSQA@mail.gmail.com>
Hi,
This is not working on Python 2.7 :(
Attached patch will add an __init__ file in the utils directory under
debugger to make it work with python 2.7
On Fri, Jun 14, 2019 at 5:17 PM Dave Page <[email protected]> wrote:
> Thanks, applied.
>
> On Fri, Jun 14, 2019 at 10:38 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> I have missed a line while implementing this. Attached is the patch to
>> fix that.
>> Although it has not caused any trouble, but still it should be changed.
>> Kindly review.
>>
>> On Mon, Jun 10, 2019 at 7:28 PM Dave Page <[email protected]> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the updated patch with fixes.
>>>>
>>>> On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Aditya
>>>>>
>>>>> Following are the review comments:
>>>>>
>>>>> - "Set breakpoint" option not working, when click it throws an
>>>>> error.
>>>>>
>>>>> Fixed.
>>>>
>>>>>
>>>>> - Create an empty function and try to debug that. It should show
>>>>> proper error message.
>>>>>
>>>>> This seems to be a bug in the debugger itself. I'll raise a bug with
>>>> simulation steps if it is. But, not sure where to raise.
>>>>
>>>>>
>>>>> - Got the following backend error when closing the connection,
>>>>> please fix this:
>>>>> - File
>>>>> "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053,
>>>>> in close_debugger_session
>>>>> conn_id=dbg_obj['exe_conn_id'])
>>>>>
>>>>> Fixed.
>>>>
>>>>>
>>>>> On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is the patch for debugger improvements. The changes include:
>>>>>> 1) Change the way debug info is stored in session. Removed redundant
>>>>>> session related code in debugger code. All the session related handling
>>>>>> done at one place.
>>>>>> 2) Fixed a bug where debugger was not opening for EPAS package
>>>>>> function.
>>>>>> 3) If a package is defined without body and we try to debug a
>>>>>> proc/func, the debugger opened a blank window. Changes made so that it will
>>>>>> throw error as "XYZ is not defined in package body."
>>>>>>
>>>>>> --
>>>>>> Thanks and Regards,
>>>>>> Aditya Toshniwal
>>>>>> Software Engineer | EnterpriseDB India | Pune
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] debugger.py27.patch (151B, 3-debugger.py27.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/debugger/utils/__init__.py b/web/pgadmin/tools/debugger/utils/__init__.py
new file mode 100644
index 00000000..e69de29b
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs
In-Reply-To: <CAM9w-_nubB2oCc-1SsVq_3t1m5akVO0-HxxwNgygsr7ST+Jtog@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox