public inbox for [email protected]  

help / color / mirror / Atom feed
From: Arun Kollan <[email protected]>
To: [email protected]
To: Dave Page <[email protected]>
Subject: Re: Styling error panel on dialogues
Date: Thu, 14 Apr 2016 14:35:00 +0100
Message-ID: <CAMVYmSDU0s-fXeUUzpw-PrvhWUS0RjYYf_EQ-H0bEuaRY9OdWg@mail.gmail.com> (raw)
In-Reply-To: <CAMVYmSADGTM2uBt1tFk9wVoZjdSpF6Ro1pZLzRDeD+ec5+VJCQ@mail.gmail.com>
References: <CAMVYmSADGTM2uBt1tFk9wVoZjdSpF6Ro1pZLzRDeD+ec5+VJCQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Team,
 The patch broke the vertical scroll on all object properties panel. I have
replaced the margin-bottom attribute with a value of 75px ( earlier it was
110px and was not required on discussion with Ashesh) .

The attached patch should fix the issue with version 1

Thank you.

Regards,
Arun

On Thu, Apr 14, 2016 at 11:51 AM, Arun Kollan <[email protected]>
wrote:

> Hi Team,
>
> Please find attached patch for fixing the styling issues with the error
> panel on dialogues.
>
> The codemirror-gutter will now extend to the bottom and will be overlayed
> on top of  the object properties status bar.
>
> Thanks.
>
> Regards,
> Arun
>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] error_panel_on_dialogue_stylingv2.patch (776B, 3-error_panel_on_dialogue_stylingv2.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css
index 3843734..ae44515 100755
--- a/web/pgadmin/static/css/overrides.css
+++ b/web/pgadmin/static/css/overrides.css
@@ -194,7 +194,7 @@ iframe {
 
 .obj_properties .backform-tab {
     position: absolute;
-    margin: 0px 0px 110px;
+    margin: 0px 0px 75px;
     padding: 0px;
     top: 0px;
     bottom: 0px;
@@ -952,3 +952,13 @@ ul.nav.nav-tabs {
 .pgadmin-controls.SQL>.CodeMirror {
   height: 500px!important;
 }
+
+/* This rule will stop Chrome apply highlighting to elements such as DIV's used as modals */ 
+*:focus {
+  outline: none;
+}
+
+/* codemirror gutters will be layed under object properties bar */
+.CodeMirror-gutters {
+  z-index: 0;
+}
\ No newline at end of file


view thread (3+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Styling error panel on dialogues
  In-Reply-To: <CAMVYmSDU0s-fXeUUzpw-PrvhWUS0RjYYf_EQ-H0bEuaRY9OdWg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox