public inbox for [email protected]help / color / mirror / Atom feed
Styling error panel on dialogues 3+ messages / 2 participants [nested] [flat]
* Styling error panel on dialogues @ 2016-04-14 10:51 Arun Kollan <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Arun Kollan @ 2016-04-14 10:51 UTC (permalink / raw) To: pgadmin-hackers; Dave Page <[email protected]> Hi Team, Please find attached patch for fixing the styling issues with the error panel on dialogues. The codemirror-gutter will now extend to the bottom and will be overlayed on top of the object properties status bar. Thanks. Regards, Arun -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers Attachments: [application/octet-stream] error_panel_on_dialogue_styling.patch (775B, 3-error_panel_on_dialogue_styling.patch) download | inline diff: diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 3843734..cdf8d5e 100755 --- a/web/pgadmin/static/css/overrides.css +++ b/web/pgadmin/static/css/overrides.css @@ -194,7 +194,7 @@ iframe { .obj_properties .backform-tab { position: absolute; - margin: 0px 0px 110px; + margin: 0px 0px 0px; padding: 0px; top: 0px; bottom: 0px; @@ -952,3 +952,13 @@ ul.nav.nav-tabs { .pgadmin-controls.SQL>.CodeMirror { height: 500px!important; } + +/* This rule will stop Chrome apply highlighting to elements such as DIV's used as modals */ +*:focus { + outline: none; +} + +/* codemirror gutters will be layed under object properties bar */ +.CodeMirror-gutters { + z-index: 0; +} \ No newline at end of file ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Styling error panel on dialogues @ 2016-04-14 13:35 Arun Kollan <[email protected]> parent: Arun Kollan <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Arun Kollan @ 2016-04-14 13:35 UTC (permalink / raw) To: pgadmin-hackers; Dave Page <[email protected]> Hi Team, The patch broke the vertical scroll on all object properties panel. I have replaced the margin-bottom attribute with a value of 75px ( earlier it was 110px and was not required on discussion with Ashesh) . The attached patch should fix the issue with version 1 Thank you. Regards, Arun On Thu, Apr 14, 2016 at 11:51 AM, Arun Kollan <[email protected]> wrote: > Hi Team, > > Please find attached patch for fixing the styling issues with the error > panel on dialogues. > > The codemirror-gutter will now extend to the bottom and will be overlayed > on top of the object properties status bar. > > Thanks. > > Regards, > Arun > -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers Attachments: [application/octet-stream] error_panel_on_dialogue_stylingv2.patch (776B, 3-error_panel_on_dialogue_stylingv2.patch) download | inline diff: diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 3843734..ae44515 100755 --- a/web/pgadmin/static/css/overrides.css +++ b/web/pgadmin/static/css/overrides.css @@ -194,7 +194,7 @@ iframe { .obj_properties .backform-tab { position: absolute; - margin: 0px 0px 110px; + margin: 0px 0px 75px; padding: 0px; top: 0px; bottom: 0px; @@ -952,3 +952,13 @@ ul.nav.nav-tabs { .pgadmin-controls.SQL>.CodeMirror { height: 500px!important; } + +/* This rule will stop Chrome apply highlighting to elements such as DIV's used as modals */ +*:focus { + outline: none; +} + +/* codemirror gutters will be layed under object properties bar */ +.CodeMirror-gutters { + z-index: 0; +} \ No newline at end of file ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Styling error panel on dialogues @ 2016-04-14 14:43 Dave Page <[email protected]> parent: Arun Kollan <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Dave Page @ 2016-04-14 14:43 UTC (permalink / raw) To: Arun Kollan <[email protected]>; +Cc: pgadmin-hackers Per discussion in the office with Arun, we're going to move the error message div into the main button/status bar which will be a better way to resolve this issue. On Thu, Apr 14, 2016 at 2:35 PM, Arun Kollan <[email protected]> wrote: > Hi Team, > The patch broke the vertical scroll on all object properties panel. I have > replaced the margin-bottom attribute with a value of 75px ( earlier it was > 110px and was not required on discussion with Ashesh) . > > The attached patch should fix the issue with version 1 > > Thank you. > > Regards, > Arun > > On Thu, Apr 14, 2016 at 11:51 AM, Arun Kollan <[email protected]> > wrote: >> >> Hi Team, >> >> Please find attached patch for fixing the styling issues with the error >> panel on dialogues. >> >> The codemirror-gutter will now extend to the bottom and will be overlayed >> on top of the object properties status bar. >> >> Thanks. >> >> Regards, >> Arun > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2016-04-14 14:43 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2016-04-14 10:51 Styling error panel on dialogues Arun Kollan <[email protected]> 2016-04-14 13:35 ` Arun Kollan <[email protected]> 2016-04-14 14:43 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox