public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yogesh Mahajan <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Require sugeestion for #1235
Date: Wed, 12 Feb 2025 17:49:59 +0530
Message-ID: <CAMa=N=NNkAQoSY58orKFP9DVEPzTEqOrErgQgOh_edv+9LJNvg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoy+MDW3CzQa40+z5raeaqL7w-wpLabk5eMUbnDp4D=NjA@mail.gmail.com>
References: <CAMa=N=MgC_2WACG-9D6s7LQUbKSRFY8_9MheCJCqud2Hnbdy9A@mail.gmail.com>
<CAMa=N=PKMsR-fWSMtsUrQ6jyFP4BWOboSN1e=u_k3eCGq9KCcA@mail.gmail.com>
<CAM9w-_=z8+MqWF28OJeRTX0fGHcynDJB9tUZANXRoAm9Qmnm6A@mail.gmail.com>
<CANVC+RGs9oyL8uc0nM87CWk7xQ=i0n3e3_LCtxzSu08X2=jW_w@mail.gmail.com>
<CAMa=N=NtQJM=WMCrjJzrmfGAkhsGVR604qkU3sjsGn3Sw6t1+A@mail.gmail.com>
<CA+OCxozSch-SXXPkx8jfSnQwYGRtzdz9C9uKT-V=j_qQ04g+-w@mail.gmail.com>
<CAMa=N=MvGWSK+gjLgwF1iPPhHAWqGZKim3YGOZGmgG+hx20GmA@mail.gmail.com>
<CA+OCxoy+MDW3CzQa40+z5raeaqL7w-wpLabk5eMUbnDp4D=NjA@mail.gmail.com>
Hi Dave,
Can you please provide your suggestions for the design? Does #1 or #2 look
good to you?
Thanks,
Yogesh Mahajan
EnterpriseDB
On Wed, Feb 12, 2025 at 5:39 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Wed, 12 Feb 2025 at 11:25, Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> Design was inspired by the File menu of different editors. Here is a
>> screenshot for VS code. However, the Open option here always opens the file
>> in a new tab.
>>
>
> A File menu is quite different from a toolbar button.
>
>
>>
>> [image: Screenshot 2025-02-12 at 4.50.59 PM.png]
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Wed, Feb 12, 2025 at 4:35 PM Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Wed, 12 Feb 2025 at 10:44, Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Dave/Team,
>>>>
>>>> I think, major votes are on the design #3 - Combine all file operations
>>>> menu in single dropdown.
>>>>
>>>
>>> I don't recall ever seeing that design pattern. Do you have any examples?
>>>
>>>
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>>
>>>> On Fri, Feb 7, 2025 at 12:13 PM Usman Khan <[email protected]> wrote:
>>>>
>>>>> Hi Yogesh,
>>>>>
>>>>> I am in favour of the third option you pointed out above but in that
>>>>> case I suggest changing the icon accordingly as the current icon usually
>>>>> gives clue about 'file-opening' operation.
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Yogesh,
>>>>>>
>>>>>> I am in favor of the "Combine all file operations menu in single
>>>>>> dropdown" solution. It is more in-line with menus of other editors and is
>>>>>> more intuitive.
>>>>>>
>>>>>> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Could you please provide your feedback/suggestions?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Yogesh Mahajan
>>>>>>> EnterpriseDB
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> For issue #1235
>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query Tool
>>>>>>>> - Open file should open file in a new tab, here are two the options to set
>>>>>>>> preference for opening file.
>>>>>>>> 1.Provide split button beside Open file button -
>>>>>>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>>>>>>> Pros -
>>>>>>>> a.Provides an easy way to set up the preference.
>>>>>>>> Cons -
>>>>>>>> a.One more addition of icon.
>>>>>>>>
>>>>>>>>
>>>>>>>> 2.Provide option with save button dropdown -
>>>>>>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>>>>>>> Pros -
>>>>>>>> a.No need to add a split button for the open icon.
>>>>>>>> Cons -
>>>>>>>> a.Open operation is listed under save options.
>>>>>>>>
>>>>>>>>
>>>>>>>> 3.Combine all file operations menu in single dropdown -
>>>>>>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>>>>>>
>>>>>>>> Pros -
>>>>>>>> a.All file related options are clubbed together like most of the
>>>>>>>> editors.
>>>>>>>> b.Allows to add more file operations with the same dropdown.(Like
>>>>>>>> Open recent - however this is out of scope of this issue.)
>>>>>>>> Cons -
>>>>>>>> c.Can't think of any.
>>>>>>>>
>>>>>>>> Could you please share your suggestions?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Yogesh Mahajan
>>>>>>>> EnterpriseDB
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> pgEdge: https://www.pgedge.com
>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>
Attachments:
[image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2025-02-12 at 4.50.59 PM.png (519.9K, 6-Screenshot%202025-02-12%20at%204.50.59%E2%80%AFPM.png)
download | view image
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Require sugeestion for #1235
In-Reply-To: <CAMa=N=NNkAQoSY58orKFP9DVEPzTEqOrErgQgOh_edv+9LJNvg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox