public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yogesh Mahajan <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: Feature Test Fix - React porting
Date: Tue, 21 Dec 2021 16:30:19 +0530
Message-ID: <CAMa=N=PnWpWgQaqivvWHfeMaJEgc7U+ZHMV0MDxcy5jpnYKujg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDc_aHw1bq9xATSyB2oubOdOnuAZdGHJexf0Bjg1RwinNw@mail.gmail.com>
References: <CAMa=N=M7TmEsEk0tD787z-obnN_805R4QyegZtFspjfddLKbug@mail.gmail.com>
<CANxoLDfH2YoCG1aVFPuzWCR95FTFgJczceH1Z-eFg2Oo24tzLA@mail.gmail.com>
<CAMa=N=Op8hASK9hRBfDXHiwrVsDn-NaH-0hUk+7gGF6L_80mHQ@mail.gmail.com>
<CANxoLDe_meHYN8DU4kc5p+6wpiKivSyyJLW26idD+7h7=wi+2A@mail.gmail.com>
<CAMa=N=MyQWGD_YwRBRXKtEVq3B1wqwCDHcOjn88XLQm+dw-Hhw@mail.gmail.com>
<CANxoLDf2pZExvAawcMcM_Bn-5D=g6iWzVEG0dWsuu-qPnAZYig@mail.gmail.com>
<CAMa=N=OHsVoYaTYdspiVHnYXhmD=Q074D8awZdTpswRuj-xgFg@mail.gmail.com>
<CANxoLDfTCoZekQvTXaapdXO6aXxaJ_F-TaYzgCpeDWEGFPbhSA@mail.gmail.com>
<CAMa=N=Px4E53Uva8x0dGdFoi-6_2G3-9J_Qu3yfJPRS3caD0_A@mail.gmail.com>
<CANxoLDc_aHw1bq9xATSyB2oubOdOnuAZdGHJexf0Bjg1RwinNw@mail.gmail.com>
Hi Team,
Please find feature tests fix that are broken due to react porting for
alert dialogues.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Tue, Nov 23, 2021 at 5:38 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Tue, Nov 23, 2021 at 4:32 PM Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix feature test failures due to react
>> porting for backup dialogue.
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Mon, Nov 22, 2021 at 6:09 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Mon, Nov 22, 2021 at 12:58 PM Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch which adds flexibility to wait for
>>>> launching pgAdmin.
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>>
>>>> On Thu, Nov 18, 2021 at 5:15 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Thanks, the patch applied.
>>>>>
>>>>> On Thu, Nov 18, 2021 at 3:23 PM Yogesh Mahajan <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch which fixes the problem related to
>>>>>> feature tests.
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Yogesh Mahajan
>>>>>> EnterpriseDB
>>>>>>
>>>>>>
>>>>>> On Fri, Nov 12, 2021 at 11:59 AM Akshay Joshi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Thanks, the patch applied.
>>>>>>>
>>>>>>> On Thu, Nov 11, 2021 at 10:04 PM Yogesh Mahajan <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Please find the attached patch which uses selenium 4.0.0a6 which
>>>>>>>> works with python 3.6.8.
>>>>>>>> Selenium 4.0.0 requires python 3.7+
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Yogesh Mahajan
>>>>>>>> EnterpriseDB
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Nov 10, 2021 at 11:59 AM Akshay Joshi <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Thanks, the patch applied. but Jenkins is failing with the below
>>>>>>>>> error:
>>>>>>>>> ERROR: No matching distribution found for selenium==4.0.0
>>>>>>>>> ERROR: Failed to install Python requirements.
>>>>>>>>>
>>>>>>>>> On Tue, Nov 9, 2021 at 2:48 PM Yogesh Mahajan <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Please find the attached patch which fixes feature tests broken
>>>>>>>>>> due to react porting changes.
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Yogesh Mahajan
>>>>>>>>>> EnterpriseDB
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> *Thanks & Regards*
>>>>>>>>> *Akshay Joshi*
>>>>>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>>>>>
>>>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Thanks & Regards*
>>>>>>> *Akshay Joshi*
>>>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>>>
>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachments:
[application/octet-stream] Feature_Test_Fix_React_Porting_v6.patch (3.0K, 3-Feature_Test_Fix_React_Porting_v6.patch)
download | inline diff:
diff --git a/web/pgadmin/feature_tests/query_tool_journey_test.py b/web/pgadmin/feature_tests/query_tool_journey_test.py
index c0e7f442c..09ce2781a 100644
--- a/web/pgadmin/feature_tests/query_tool_journey_test.py
+++ b/web/pgadmin/feature_tests/query_tool_journey_test.py
@@ -150,6 +150,9 @@ class QueryToolJourneyTest(BaseFeatureTest):
def _test_history_tab(self):
self.page.clear_query_tool()
+ self.page.driver.switch_to.frame(
+ self.page.driver.find_element_by_tag_name("iframe"))
+
editor_input = self.page.find_by_css_selector(
QueryToolLocators.query_editor_panel)
self.page.click_element(editor_input)
@@ -197,6 +200,8 @@ class QueryToolJourneyTest(BaseFeatureTest):
self.page.click_tab(self.query_editor_tab_name)
self.page.clear_query_tool()
+ self.page.driver.switch_to.frame(
+ self.page.driver.find_element_by_tag_name("iframe"))
self.page.click_element(editor_input)
# Check if 15 more query executed then the history should contain 17
@@ -221,6 +226,8 @@ class QueryToolJourneyTest(BaseFeatureTest):
self._test_toggle_generated_queries()
def _test_history_query_sources(self):
+ self.page.driver.switch_to.frame(
+ self.page.driver.find_element_by_tag_name("iframe"))
self.page.click_tab(self.query_editor_tab_name)
self._execute_sources_test_queries()
@@ -297,7 +304,11 @@ class QueryToolJourneyTest(BaseFeatureTest):
query = "SELECT pk_column FROM %s" % self.test_editable_table_name
self.page.execute_query(query)
# Discard changes made by previous test to data grid
- self.page.click_modal('Yes')
+ self.page.driver.switch_to.default_content()
+ self.page.click_modal('Yes', True)
+ self.page.driver.switch_to.frame(
+ self.page.driver.find_element_by_tag_name("iframe"))
+
icon_exists = self.page.check_if_element_exist_by_xpath(
QueryToolLocators.editable_column_icon_xpath
)
@@ -418,7 +429,8 @@ class QueryToolJourneyTest(BaseFeatureTest):
self.page.click_element(
self.page.find_by_css_selector(QueryToolLocators.btn_clear_history)
)
- self.page.click_modal('Yes')
+ self.driver.switch_to.default_content()
+ self.page.click_modal('Yes', True)
def _navigate_to_query_tool(self):
self.page.expand_database_node("Server", self.server['name'],
@@ -448,7 +460,11 @@ class QueryToolJourneyTest(BaseFeatureTest):
discard_changes_modal=False):
self.page.execute_query(query)
if discard_changes_modal:
- self.page.click_modal('Yes')
+ self.driver.switch_to.default_content()
+ self.page.click_modal('Yes', True)
+ self.page.driver.switch_to.frame(
+ self.page.driver.find_element_by_tag_name("iframe"))
+
enumerated_should_be_editable = enumerate(cols_should_be_editable, 1)
import time
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: Feature Test Fix - React porting
In-Reply-To: <CAMa=N=PnWpWgQaqivvWHfeMaJEgc7U+ZHMV0MDxcy5jpnYKujg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox