public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Coleman <[email protected]>
To: [email protected]
Subject: change to Docker entrypoint.sh
Date: Thu, 20 Jun 2019 12:31:40 -0400
Message-ID: <CANNh3aUNwnmYAAzFLL_vt1JRy9TH_TNXRtEHpBVZ9wYVytSdaA@mail.gmail.com> (raw)

Hi All!

I am new to this, so I apologize beforehand if it's not entirely kosher,
but I have a proposed change to the Dockerfile entrypoint.sh to allow for
configurable servers.json filename path.

The reasoning behind this is that I have a Kubernetes deployment of pgadmin
where I build a ConfigMap sort of dynamically. I can make the file appear
in /pgadmin4, but it removes the contents of the directory for me
(helpful!). Instead, I put it into a separate directory and set a new
environment variable that defaults to the old pathname
(backwards-compatible!) but allows me to set a custom environment variable
in my custom Helm chart for my deployment.

The code is here:
https://github.com/penguincoder/pgadmin4/commit/0865400385ac0d03bf69d183e8cd9aaec6dcf318

Is this something that anyone is interested in?
Does it meet your coding standards?
What do I do next?

I would love to move back to the "official" pgadmin container.

Thanks for your time,

Andrew

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: change to Docker entrypoint.sh
  In-Reply-To: <CANNh3aUNwnmYAAzFLL_vt1JRy9TH_TNXRtEHpBVZ9wYVytSdaA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox