public inbox for [email protected]
help / color / mirror / Atom feedFrom: Cyril Jouve <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: RM5841: server.username can be empty when using .pg_service.conf
Date: Sat, 19 Sep 2020 14:52:10 +0200
Message-ID: <CANhjAHxpK_j_w1Zmu5Keofsqz4bbcpsnKR8ybNPZUqQNN-DANg@mail.gmail.com> (raw)
fix for https://redmine.postgresql.org/issues/5841
Attachments:
[application/octet-stream] 0001-server.username-can-be-None-when-using-.pg_service.c.patch (1.2K, 3-0001-server.username-can-be-None-when-using-.pg_service.c.patch)
download | inline diff:
From 68b788d16e750097d1de1119ee043d6f353a6a2c Mon Sep 17 00:00:00 2001
From: Cyril Jouve <[email protected]>
Date: Sat, 19 Sep 2020 14:39:56 +0200
Subject: [PATCH] server.username can be None when using .pg_service.conf
---
web/pgadmin/browser/server_groups/servers/__init__.py | 8 --------
1 file changed, 8 deletions(-)
diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py
index ed8fae0f0..ccb47f1d3 100644
--- a/web/pgadmin/browser/server_groups/servers/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/__init__.py
@@ -1280,14 +1280,6 @@ class ServerNode(PGChildNodeView):
if server is None:
return bad_request(self.not_found_error_msg())
- # Return if username is blank
- if server.username is None:
- return make_json_response(
- status=200,
- success=0,
- errormsg=gettext(
- u"Please enter the server details to connect")
- )
if current_user and hasattr(current_user, 'id'):
# Fetch User Details.
user = User.query.filter_by(id=current_user.id).first()
--
2.28.0
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: RM5841: server.username can be empty when using .pg_service.conf
In-Reply-To: <CANhjAHxpK_j_w1Zmu5Keofsqz4bbcpsnKR8ybNPZUqQNN-DANg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox