public inbox for [email protected]  

help / color / mirror / Atom feed

From: Cyril Jouve <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: More idiomatic python3 + fix some tests
Date: Tue, 1 Sep 2020 11:06:42 +0200
Message-ID: <CANhjAHyDZYjfyedEyQQCt_JSnYPh9z0UBCdZtxshB5xY0d4ONg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdCapDy6EXx9CKXr7BPJ5zbkefSCBX6HwnQDGXrZ3iX-Q@mail.gmail.com>
References: <CANhjAHykjZOPe0=MLkTvqjvmUfK1F=HX+dE4ORrVdEPf+wwAfg@mail.gmail.com>
	<CANxoLDdCapDy6EXx9CKXr7BPJ5zbkefSCBX6HwnQDGXrZ3iX-Q@mail.gmail.com>

thanks :)

and sure, I'll run the linter next time!

have you thought of automatic code formatters instead like yapf or black?



Le lun. 31 août 2020 à 13:18, Akshay Joshi <[email protected]>
a écrit :

> Hi Cyril
>
> Thanks, patch applied. Please make sure to run "yarn run pep8" before
> sending the patch.
>
> On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve <[email protected]> wrote:
>
>> Hello,
>>
>> patch 1 to 6 generated mostly using 2to3:
>> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts
>> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter
>> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms
>> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass
>> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange
>> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode
>>
>> patch 7 fixes change_password tests:
>> Less that min length : min is 8 instead of 6
>> Valid password : use an user different than admin user / mock mail module
>>
>> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using
>> simplejson like in all other modules).
>>
>> Regards,
>> Cyril
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: More idiomatic python3 + fix some tests
  In-Reply-To: <CANhjAHyDZYjfyedEyQQCt_JSnYPh9z0UBCdZtxshB5xY0d4ONg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox