public inbox for [email protected]  

help / color / mirror / Atom feed

From: Victoria Henry <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11
Date: Tue, 12 Jun 2018 12:06:19 -0400
Message-ID: <CANxYE3L=oWCmtxZanz=N-QFoiR_Q_AyzkXJ_DPCq_9V2WpcU1g@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELfWXEyeauH_SgVvWBEtKxTqRFyDCUY8Jvr7qnGUfN=F9A@mail.gmail.com>
References: <CAFOhELdzaBaPE1ev9t61+e3fbTDYNsMod1wMLRmG3YAWP5jpug@mail.gmail.com>
	<CAFOhELdQLJHccik87AkTPY5nop0P3mF1xy2wEBNkoSSssmumMQ@mail.gmail.com>
	<CA+OCxowGMOcrHAv4Q4PSu58PjQV3DfYtRuvba6wg-G_27uMjhA@mail.gmail.com>
	<CAFOhELfWXEyeauH_SgVvWBEtKxTqRFyDCUY8Jvr7qnGUfN=F9A@mail.gmail.com>

Hi Khushboo,

The following change is allowing the creation of procedures in postgresql
versions less then 11 and also GreenPlum

--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
@@ -71,11 +71,7 @@ define('pgadmin.node.procedure', [
         if ('catalog' in node_hierarchy)
           return false;

-        // Procedures supported only in PPAS
-        return (
-          'server' in node_hierarchy &&
-            node_hierarchy['server'].server_type == 'ppas'
-        );
+        return true;

Now that the Procedures are a thing in Postgresql maybe they should live in
their own module.
In the tests for trigger functions we are not consistent on the naming of
the utils , in some places we call it funcs_utils in others
trigger_funcs_utils.

Thanks
​
Victoria & Joao

On Tue, Jun 12, 2018 at 3:10 AM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached updated patch.
>
> On Fri, Jun 8, 2018 at 2:21 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please ignore my previous patch, find the attached updated one.
>>>
>>
>> I found a couple of issues with this:
>>
>> - Clicking the + button on the Parameters tab does nothing in either
>> Create or Edit modes
>>
>> Fixed
>
>> - The debugger fails to start (though, perhaps that's because the plugin
>> doesn't have Ashesh's latest patches in it).
>>
>> FYI, I was trying to test the debugger with:
>>
>> -- PROCEDURE: public.dummy_proc(integer)
>>
>> -- DROP PROCEDURE public.dummy_proc(integer);
>>
>> CREATE OR REPLACE  PROCEDURE public.dummy_proc(
>> id integer)
>> LANGUAGE 'plpgsql'
>>
>> AS $BODY$BEGIN
>>   raise notice 'id is %', id;
>> END;$BODY$;
>>
>> Fixed. Tested with the latest code of the plugin.
>
>> Thanks!
>>
>> Thanks,
> Khushboo
>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM 3362 - Fix the functions for PG v11, and add support procedure for PG v11
  In-Reply-To: <CANxYE3L=oWCmtxZanz=N-QFoiR_Q_AyzkXJ_DPCq_9V2WpcU1g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox