public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Pramod Ahire <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Quick search for menu items & help articles
Date: Mon, 25 Jan 2021 15:53:20 +0530
Message-ID: <CANxoLDc3yh3B0MtKVjaN5wAWTM_1UaoCsCmmUVp4vFBR6KdECw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CA+OCxozgWnBkzORFfLD1o0X4Zq9izG26a+LZUZ8encP-Qn6mew@mail.gmail.com>
<[email protected]>
<CA+OCxoweuRoV-NC8Q3Go1oU_MSKy2+ntHF7h_Sinrr9um=XwRw@mail.gmail.com>
<CANxoLDe2APE-=h3+8NUuoj+ArH_R6U4vUepRWna5gwxaq2MK2Q@mail.gmail.com>
<CA+OCxozwzdBa5OBj_=gTNo0V6F0M_Ne3H-q9GHPgfP7ZqSF+cQ@mail.gmail.com>
<CANxoLDfF+-EoPpwC0F-Fh0rJKihaiv9Q1n5r7V0A9_vfqUudyQ@mail.gmail.com>
<[email protected]>
<[email protected]>
Hi Pramod
The patch is not applied, maybe you need to rebase and send the patch again.
On Wed, Jan 20, 2021 at 4:36 PM Pramod Ahire <[email protected]>
wrote:
> Hi Team,
>
>
>
> Sorry for the inconvenience, kindly please discard previous email.
>
>
>
> Please review patch attached to this email.
>
> Changes as below :
>
> 1. Added complete quick search menu to help dropdown
> 2. Added message to each disabled menu item to describe why it can be
> disabled
>
> 3. Info icon design to menu items results if disabled
> 4. Standard/dark/high contrast theme supports
>
> NOTE: “Initial backend search mechanism patch by: Murtuza Zabuawala”
>
>
>
> Thanks !
>
>
>
> *Pramod Ahire*
>
> *Software Engineer*
>
>
>
> [image:
> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMP...]
>
>
>
> C: +91-020-66449600/601
>
> D: +91-9028697679
>
> *edbpostgres.com <http://edbpostgres.com>*
>
>
>
>
>
> *From: *Pramod Ahire <[email protected]>
> *Date: *Wednesday, 20 January 2021 at 4:19 PM
> *To: *Akshay Joshi <[email protected]>, Dave Page <
> [email protected]>
> *Cc: *pgadmin-hackers <[email protected]>
> *Subject: *Re: Quick search for menu items & help articles
>
>
>
> Hi Team,
>
>
>
> As per inputs from you all, made changes & attached patch with this email.
>
>
>
> Kindly please have a review & do let me know if missed anything.
>
>
>
> Thanks !
>
>
>
> *Pramod Ahire*
>
> *Software Engineer*
>
>
>
> [image:
> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMP...]
>
>
>
> C: +91-020-66449600/601
>
> D: +91-9028697679
>
> *edbpostgres.com <http://edbpostgres.com>*
>
>
>
>
>
> *From: *Akshay Joshi <[email protected]>
> *Date: *Friday, 15 January 2021 at 3:34 PM
> *To: *Dave Page <[email protected]>
> *Cc: *Pramod Ahire <[email protected]>, pgadmin-hackers <
> [email protected]>
> *Subject: *Re: Quick search for menu items & help articles
>
>
>
>
>
>
>
> On Fri, Jan 15, 2021 at 3:15 PM Dave Page <[email protected]> wrote:
>
>
>
>
>
> On Fri, Jan 15, 2021 at 9:43 AM Akshay Joshi <
> [email protected]> wrote:
>
> Hi Dave
>
>
>
> On Fri, Jan 15, 2021 at 2:46 PM Dave Page <[email protected]> wrote:
>
> Hi
>
>
>
> On Fri, Jan 15, 2021 at 7:23 AM Pramod Ahire <
> [email protected]> wrote:
>
> Hi Dave,
>
>
>
> Thank you for comments ! I had described points below. Please do let me
> know if anything missing.
>
>
>
> *From: *Dave Page <[email protected]>
> *Date: *Thursday, 14 January 2021 at 10:26 PM
> *To: *Pramod Ahire <[email protected]>
> *Cc: *pgadmin-hackers <[email protected]>
> *Subject: *Re: Quick search for menu items & help articles
>
>
>
> Hi
>
>
>
> On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire <
> [email protected]> wrote:
>
> Hi Team,
>
>
>
> Please find the attached designs & patch that contains complete
> functionality except below to do for quick search.
>
>
>
> To Do:
>
>
>
> - Unit test cases are not that sufficient to cover complete code, but
> will be working in background to cover up those one
> - In pgadmin, for disabled menu items we need to add info that will
> describe why menu has disabled & how it will be enabled. Either another way
> to enable all of them & show respective reason in popup that menu is
> disabled for.
>
>
>
> Please do let me know if I missed anything or suggestion of yours.
>
>
>
> Looks very good. I haven't done an extensive code review/test, but two
> things spring to mind immediately:
>
>
>
> 1) I think the search box should be the top item on the Help menu. I do
> not think it should be on the far end of the menu bar, as it looks too much
> like it will search for data (think of search on a website).
>
>
>
> - As we are showing menu items as well in search results, it can be
> redundant for end user & increase duplications of menu items. Please advise
> your thoughts on this.
>
>
>
> The search box could be on the Help menu, with results shown in a sub-menu
> under it.
>
>
>
> Another more simple option would be to move the search icon to be directly
> after the Help menu (which would hint that it's related to the menus), but
> I'm also concerned about the number of items on the top menu - we're
> getting to the point that 'common' window sizes would show the hamburger
> menu by default.
>
>
>
> I personally feel we should not add the search box on the Help menu,
> it should be kept separate with a placeholder indicating what is it for. We
> can move the search icon after the Help menu.
>
>
>
> What is your reasoning? It is, after all, specifically designed to help
> people.
>
>
>
> OK, I have seen a couple of applications where the search box is
> inside the Help menu, agree with your point.
>
>
>
>
>
>
>
> 2) Do we need another loading icon? Surely there's one in the source tree
> already that we can use?
>
>
>
> - As we are loading help articles count in background, so I have added
> background loading icon to show near to count of results. Our existing icon
> is of blue & white circle combination, which will be more useful to show
> foreground loading.
>
>
>
> Hmm, OK.
>
>
>
>
>
> Please do let me know your valuable inputs on this.
>
>
>
>
>
> *Pramod Ahire*
>
> *Software Engineer*
>
>
>
> [image:
> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMP...]
>
>
>
> C: +91-020-66449600/601
>
> D: +91-9028697679
>
> *edbpostgres.com <http://edbpostgres.com>*
>
>
>
>
>
>
>
>
>
>
>
>
> --
>
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>
>
>
> --
>
> *Thanks & Regards*
>
> *Akshay Joshi*
>
> *pgAdmin Hacker | Principal Software Architect*
>
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
>
>
>
> --
>
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>
>
>
> --
>
> *Thanks & Regards*
>
> *Akshay Joshi*
>
> *pgAdmin Hacker | Principal Software Architect*
>
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] image001.png (68.4K, 3-image001.png)
download | view image
[image/png] image002.png (68.4K, 4-image002.png)
download | view image
[image/png] image003.png (68.4K, 5-image003.png)
download | view image
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Quick search for menu items & help articles
In-Reply-To: <CANxoLDc3yh3B0MtKVjaN5wAWTM_1UaoCsCmmUVp4vFBR6KdECw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox