public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Harshal Dhumal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation
Date: Tue, 22 Jan 2019 16:29:03 +0530
Message-ID: <CANxoLDc5b+Tx4-nPyKtWP7S4UhJo8bM8qSV7MAfZqTRJanO=EQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELc-iT6omPfDaT==4vZkZ9H2ZkdTJXGSrmFA-=k7CfSMsA@mail.gmail.com>
References: <CAFiP3vxc4KKGzKboMcMJBpMpVJGkhcthgb89YbqTtVknbWhw4A@mail.gmail.com>
<CAFiP3vyCZ7OZ8o1p7Z79jGD8omB5P8n7bE9L8vX0dQoPZwNbdQ@mail.gmail.com>
<CANxoLDfEG1Vzxb=YtXbUkRfj43WO=CAaUhdtPy-mP91eDKNuCg@mail.gmail.com>
<CAFOhELc-iT6omPfDaT==4vZkZ9H2ZkdTJXGSrmFA-=k7CfSMsA@mail.gmail.com>
Thanks patch applied.
On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi <
[email protected]> wrote:
> The patch looks good to me.
>
> On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Khushboo
>>
>> Can you please review it.
>>
>> On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find attached updated patch.
>>> In this patch I have fixed two issues:
>>> i. Dialog tab navigation should work even if focus is on footer buttons
>>> (Save, Cancel, etc..)
>>> ii. Focus should be set to first editable element of dialog when tab
>>> cycle goes through all editable footer buttons.
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>> This patch fixes Dialog tabset keyboard navigation.
>>>> This regression was caused due to bootstrap 4 changes.
>>>> Also I have added jasmine test cases for the same
>>>>
>>>>
>>>> --
>>>> *Harshal Dhumal*
>>>> *Sr. Software Engineer*
>>>>
>>>> EnterpriseDB India: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation
In-Reply-To: <CANxoLDc5b+Tx4-nPyKtWP7S4UhJo8bM8qSV7MAfZqTRJanO=EQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox