public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Pradip Parkale <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.
Date: Mon, 30 Mar 2020 17:45:23 +0530
Message-ID: <CANxoLDc6=UFLgiSH-8mCKZqxLhMz5L+bT0BCc58OzGiJVq2P1w@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6Su=AhDcj6Lnbuw1Jwy8445ZOWE=uwfrSi-08=2zpFaBLg@mail.gmail.com>
References: <CAJ9T6SuQPUEnfO3G2S17q02SC=RQJ-4BrO_m-nWxoi_7g46i6w@mail.gmail.com>
	<CANxoLDcQcg_yorAyoY5dNdRED2dNtz_2P-Lz6-akrab_Uxu8VA@mail.gmail.com>
	<CAJ9T6Su=AhDcj6Lnbuw1Jwy8445ZOWE=uwfrSi-08=2zpFaBLg@mail.gmail.com>

Thanks, patch applied.

On Mon, Mar 30, 2020 at 5:25 PM Pradip Parkale <
[email protected]> wrote:

> Hi Akshay,
>
> Please find the attached patch.
>
> On Fri, Mar 27, 2020 at 1:17 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Pradip
>>
>> Following things are not working, please fix and resend the patch:
>>
>> Object selection (First) Page:
>>
>>    - If there is no object in the backgrid to select then tab navigation
>>    not proceed after the headers.
>>
>> Fixed.
>
>>
>>    - Tab navigation not working for 'Select All' checkbox in the
>>    backgrid cell.
>>
>> Fixed.
>
>> Privileges selection (Second) Page:
>>
>>    - Tab navigation not working for the 'Delete' button in the
>>    backgrid cell.
>>
>> This logic was added even before my patch(1st Patch). User needs to press
> the 'space' key to delete the privilege added.
>
>>
>> On Fri, Mar 27, 2020 at 9:47 AM Pradip Parkale <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a patch for tab key navigation on grant_wizard.
>>>
>>> This patch includes:
>>>
>>>    1. Added code to make tab navigation working in grant_wizard.
>>>    2. Added entry for .scss to change the shadow of  'ajs-close' button.
>>>
>>> This patch also includes the code to allow the user to use the keyboard
>>> to update the Backgrid cell DateTime picker control.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.
  In-Reply-To: <CANxoLDc6=UFLgiSH-8mCKZqxLhMz5L+bT0BCc58OzGiJVq2P1w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox