public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved
Date: Tue, 5 Nov 2019 11:01:16 +0530
Message-ID: <CANxoLDc8FQ7bRNz+YFAiM+dBuXqpohzvSSfhthOgbh0CAZy-_A@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mWORTqO4i6QFtyH_d7HZ9Mjyd7-N1TqRaLHYcBK-2FoA@mail.gmail.com>
References: <CAM9w-_mq7LEmQGZiruSjNAkGnTGtXRAF+h6eM7syD4KF+0ovHQ@mail.gmail.com>
<CA+OCxozYJ8RQEBnfE3r-zAxccwY05F6CExocNsKs82w-7Y=pRQ@mail.gmail.com>
<CA+OCxozd=s4vL5w8yCH2oF_ZF0mrUY3n24oCLpwSsNgfU9t7aw@mail.gmail.com>
<CAM9w-_mByKngJX_tX2ED8JHgaEFXRpMuyZMTX5d=ww4DKZ2qow@mail.gmail.com>
<CA+OCxoxLD3mp=vYyMMgiBvT_sX6w9ayTcUg-=MCBic2LFsXMkw@mail.gmail.com>
<CAM9w-_kFtokCkMnsgG4r9XLcgZc4KJcapXkJC7C+9atcZ0cBLw@mail.gmail.com>
<CAM9w-_mWORTqO4i6QFtyH_d7HZ9Mjyd7-N1TqRaLHYcBK-2FoA@mail.gmail.com>
Hi Aditya
I have tested it. Reset functionality not working when preference setting
is set to False. Please fix and resend the patch.
On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> As discussed, extending the changes to Reset button also. Warning will
> appear for Reset button now if opted in preferences and changes are not
> saved.
> Note that, the preference option is same for Close and Reset button.
>
> Kindly review.
>
> On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>>
>>
>> On Wed, Oct 30, 2019 at 3:44 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> I just found an, umm, embarrassing issue with this. It asks for the
>>>>> cancel confirmation even when pressing the OK button :-o
>>>>>
>>>> Tested all but missed the obvious. Bad miss :/
>>>> Attached is the patch to fix the issue.
>>>>
>>>
>>> Thanks - applied. Should we also warn on Reset? That seems logical to me.
>>>
>> Can be added. Preference option should be common for both Cancel and
>> Reset. Will send an add-on patch for this.
>>
>>>
>>>
>>>>
>>>>> Can you fix that ASAP please?
>>>>>
>>>>> On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Thanks, applied.
>>>>>>
>>>>>> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Hackers,
>>>>>>>
>>>>>>> Attached is the patch to warn the user before closing an unsaved
>>>>>>> properties dialog.
>>>>>>> Additionally, I have added a preference option in Browser->Display
>>>>>>> where the user can disable this. Default is enabled.
>>>>>>> Docs updated.
>>>>>>>
>>>>>>> Kindly review.
>>>>>>>
>>>>>>> --
>>>>>>> Thanks and Regards,
>>>>>>> Aditya Toshniwal
>>>>>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved
In-Reply-To: <CANxoLDc8FQ7bRNz+YFAiM+dBuXqpohzvSSfhthOgbh0CAZy-_A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox