public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Sanket Mehta <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: FTS configuration node
Date: Fri, 13 May 2016 18:20:43 +0530
Message-ID: <CANxoLDcAYhKC2TH_ZGwioTRYQY7Da+Jkq__-OrGWJ958WddQ2A@mail.gmail.com> (raw)
In-Reply-To: <CA+yw=mM1X5E+4W=vD19HBjaCvb0dQSzCU3nw4CksrvHtRqd0MQ@mail.gmail.com>
References: <CA+yw=mN+xtYDw_E-H2jexDtrY60kb=V5bMwDWBmm8PBDSoSnfw@mail.gmail.com>
<CAFiP3vx=_Tm5c5pYYkU01LEV=rV9mUTgZjdLU6fPaqehhwF1=Q@mail.gmail.com>
<CA+yw=mMENphfZiQeU39Th7+E5aOK2eUpRmg5OdomV1RCzouE_w@mail.gmail.com>
<CA+yw=mM1X5E+4W=vD19HBjaCvb0dQSzCU3nw4CksrvHtRqd0MQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Sanket
Below are my review comments:
- Add button should be disabled in Tokens tab while creating.
- Unable to click on down arrow for token select control.
- Title should be change from "Create FTS-dictionaries" to "Create FTS
-Configuration".
- Tree node is not getting refreshed on name change.
- Unable to rename FTS Configuration when name contains any capital
letter.
- If user tries to add already existing token then respective row in the
backgrid should be highlighted.
- "URL not found" when click on SQL help icon from the properties dialog.
- SQL should not be generated when remove and add the same token again.
Currently it is creating two sql's one for remove and another is for add.
- *Fix for the above issue is*: - Add "keys: ['token']," to TokenModel
in your js file.
On Fri, May 13, 2016 at 2:58 PM, Sanket Mehta <[email protected]
> wrote:
> Hi All,
>
> Last patch for FTS configuration does not contain node.ui.js file
> Kindly ignore it.
>
> Here is the new revised patch attached with this mail.
> Please do review it and let me know if any changes required
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Thu, May 12, 2016 at 4:38 PM, Sanket Mehta <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA the revised patch.
>> Please do review it and let me know if anything is not proper.
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal <
>> [email protected]> wrote:
>>
>>> + patch link
>>>
>>>
>>> http://www.postgresql.org/message-id/[email protected]....
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB <http://www.enterprisedb.com;
>>>
>>> On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA first patch for FTS configuration node.
>>>>
>>>> It depends upon backgrid select2cell multi select control, for which
>>>> Harshal has sent the patch recently.
>>>> Please do apply his patch first and then apply this patch.
>>>>
>>>> Please do review it and let me know if any changes are required.
>>>>
>>>>
>>>> Regards,
>>>> Sanket Mehta
>>>> Sr Software engineer
>>>> Enterprisedb
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list ([email protected])
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>>
>>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: FTS configuration node
In-Reply-To: <CANxoLDcAYhKC2TH_ZGwioTRYQY7Da+Jkq__-OrGWJ958WddQ2A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox