public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences
Date: Thu, 29 Aug 2019 14:16:09 +0530
Message-ID: <CANxoLDcN_GShyAGqFov_z=h0Bbw2_Yes8Q3bcWpMMo=U=Xd2MA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_nVWi1ngsT+U0VD0=XVnhGm7QwSu6cVahCSs_6XVaCbSw@mail.gmail.com>
References: <CAM9w-_kd2NkXxvRojtyTwtxTR=a_oAS6i1LO1Jgs15zVmYK3fQ@mail.gmail.com>
<CA+OCxoymKPQPH-rcvw0R3xpdtk+MwKhB18g=QMCqPat78E0uUA@mail.gmail.com>
<CAM9w-_nixiUdOheqo4HQyxLXL511B+40KEpVkJ11ssMNzg2J6g@mail.gmail.com>
<CAM9w-_mC3Kzr4nHx-xuz3pjbba2J0U7j1nnXA4yEXEEdW_Yadw@mail.gmail.com>
<CAM9w-_nVWi1ngsT+U0VD0=XVnhGm7QwSu6cVahCSs_6XVaCbSw@mail.gmail.com>
Thanks patch applied.
On Thu, Aug 29, 2019 at 12:29 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the updated patch.
> The patch also includes some RE-SQL log additions and a change in resql
> code where msql was failing if scenario data had dict data types. Code is
> changed to convert dict to string before forming the URL.
>
> Kindly review.
>
> On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Kindly hold on with the patch. I think I have missed few things. :P
>> Will send an updated patch.
>>
>> On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch containing further changes to sequences RE-SQL
>>> test cases. Changes include MSQL test cases, ACL test cases and allow run
>>> sequences test cases on EPAS servers.
>>>
>>> Kindly review.
>>>
>>> On Mon, Jul 15, 2019 at 7:26 PM Dave Page <[email protected]> wrote:
>>>
>>>> Thanks, committed.
>>>>
>>>> On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Attached is the patch to add RE-SQL test cases for sequences. When
>>>>> running the test cases, I also found an issue (#4470
>>>>> <https://redmine.postgresql.org/issues/4470;). The fix for it is
>>>>> included in the patch.
>>>>>
>>>>> Kindly review.
>>>>>
>>>>> --
>>>>> Thanks and Regards,
>>>>> Aditya Toshniwal
>>>>> Software Engineer | EnterpriseDB India | Pune
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences
In-Reply-To: <CANxoLDcN_GShyAGqFov_z=h0Bbw2_Yes8Q3bcWpMMo=U=Xd2MA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox