public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][RM6976] Allow large comments and resize textarea
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM6976] Allow large comments and resize textarea
@ 2021-11-05 06:37  Aditya Toshniwal <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2021-11-05 06:37 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached patch will allow textrea's to be resized and have more than 255
chars.
Please review.

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM6976.patch (1.1K, 3-RM6976.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/Theme/index.jsx b/web/pgadmin/static/js/Theme/index.jsx
index 3a0118802..3470162ea 100644
--- a/web/pgadmin/static/js/Theme/index.jsx
+++ b/web/pgadmin/static/js/Theme/index.jsx
@@ -101,6 +101,7 @@ basicSettings = createMuiTheme(basicSettings, {
       },
       inputMultiline: {
         padding: basicSettings.spacing(0.75, 1.5),
+        resize: 'auto',
       },
       adornedEnd: {
         paddingRight: basicSettings.spacing(1.5),
diff --git a/web/pgadmin/static/js/components/FormComponents.jsx b/web/pgadmin/static/js/components/FormComponents.jsx
index 9da3e0945..5bad4c7c4 100644
--- a/web/pgadmin/static/js/components/FormComponents.jsx
+++ b/web/pgadmin/static/js/components/FormComponents.jsx
@@ -345,7 +345,7 @@ export const InputText = forwardRef(({
       className={classes.formInput}
       inputProps={{
         id: cid,
-        maxLength: maxlength,
+        maxLength: controlProps?.multiline ? null : maxlength,
         'aria-describedby': helpid,
         ...(type ? {pattern: !_.isUndefined(controlProps) && !_.isUndefined(controlProps.pattern) ? controlProps.pattern : patterns[type]} : {})
       }}


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM6976] Allow large comments and resize textarea
@ 2021-11-07 05:53  Akshay Joshi <[email protected]>
  parent: Aditya Toshniwal <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-11-07 05:53 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks, the patch applied.

On Fri, Nov 5, 2021 at 12:08 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached patch will allow textrea's to be resized and have more than 255
> chars.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2021-11-07 05:53 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 06:37 [pgAdmin][RM6976] Allow large comments and resize textarea Aditya Toshniwal <[email protected]>
2021-11-07 05:53 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox