public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Neel Patel <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab
Date: Tue, 9 May 2017 13:09:35 +0530
Message-ID: <CANxoLDcQV7socMUmvXxL0V-E=W9LUoYzmgoMRb-s1FyYtOzrXw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozAs+3T-Z_rJeZd0TLDr4gbWZdhPi4pYq8UUbM0nqLzVA@mail.gmail.com>
References: <CACCA4P3zyGfc7nFLCCiq8O4OU=ErTkmvR=mYMOQOao2-T_RJ_A@mail.gmail.com>
	<CA+OCxozAs+3T-Z_rJeZd0TLDr4gbWZdhPi4pYq8UUbM0nqLzVA@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Thanks patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave Page <[email protected]> wrote:

> Akshay, could you review this please?
>
> Thanks.
>
> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <[email protected]>
> wrote:
>
>> Hi,
>>
>> Please find attached patch file with the fix of RM #2328 - [Runtime]:
>> Unable to launch query tool and debugger in new browser tab.
>>
>> I have used Qt 5.8 with webkit mentioned in below URL.
>>
>> https://github.com/annulen/webkit/releases
>>
>>
>> As there was a bug in QWebKit regarding "unload" event. We have raised
>> and also they have provided patch file to fix this issue. I have applied
>> the patch in linux and compile the webkit and tested the attached patch
>> with compiled webkit which is now working fine.
>>
>> Below is the link for reference regarding unload issue. They have
>> provided test webkit release for Mac in below URL but for other platform we
>> need to apply the patch and compile the webkit until they provide
>> webkit-releases for all platforms.
>>
>> https://github.com/annulen/webkit/issues/519
>>
>> Do review it and let me know in case of any issue.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


view thread (17+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab
  In-Reply-To: <CANxoLDcQV7socMUmvXxL0V-E=W9LUoYzmgoMRb-s1FyYtOzrXw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox