public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Patch for SonarQube fixes.
Date: Mon, 18 Jan 2021 13:09:41 +0530
Message-ID: <CANxoLDcUXdS45tEsk98SpPaX4Wh5YdErgPPM2B+JyOgmLddheQ@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AO3tVZMT68DyMLyc6w+za9sHA+NHEs_rosfVGNP=kgxeQ@mail.gmail.com>
References: <CAOBg0AO3tVZMT68DyMLyc6w+za9sHA+NHEs_rosfVGNP=kgxeQ@mail.gmail.com>
Thanks, patch applied.
On Mon, Jan 18, 2021 at 11:15 AM Nikhil Mohite <
[email protected]> wrote:
> Hi Team,
>
> I have fixed a few sonarQube issues, PFA patch
> Details as follows:
>
> 1. Preferences:
>
> - Refactor this function to reduce its Cognitive Complexity from 18 to
> the 15 allowed.
> - Merge this if statement with the enclosing one.
> - Define a constant instead of duplicating this literal 'tab settings'
> 5 times.
>
> 2. Connection:
>
> - Remove this unneeded "pass".
>
> 3. Sqleditor:
>
> - Remove this useless assignment to variable "msgDiv".
>
> 4. Debugger:
>
> - Review this useless assignment: "index" already holds the assigned
> value along all execution paths.
> - 'label' is already declared in the upper scope.
> - 'label' is already declared in the upper scope.
> - 'browser_preferences' is already declared in the upper scope.
>
> 5. FileManager:
>
> - 'path' is already declared in the upper scope.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Patch for SonarQube fixes.
In-Reply-To: <CANxoLDcUXdS45tEsk98SpPaX4Wh5YdErgPPM2B+JyOgmLddheQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox