public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Refactor: Registry Classes
Date: Wed, 23 Jun 2021 13:22:30 +0530
Message-ID: <CANxoLDcUuG1+yO0nGjXvZGwxnpofwyfsBNjOimSbvr40-6UPFw@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmoxQfhVhGUC2ArMkCPUoWiBusu-z6=0PR8OiZfOMQpnWwg@mail.gmail.com>
References: <CAG7mmoz=wOOc3QiZDZuSwonFue_sowcZRtZLK_M0o839ZPnJ_Q@mail.gmail.com>
<CAG7mmoxQfhVhGUC2ArMkCPUoWiBusu-z6=0PR8OiZfOMQpnWwg@mail.gmail.com>
Hi Ashesh
Following are the review comments:
- Fixed PEP8 issues.
- In "dynamic_registry/__init__.py" decorator @classmethod used for "
*_get*" and "*_load_modules*" methods which are actually outside of the
class. Even constructor also outside of the class.
- Remove unused imports from "driver/registry.py"
- Fixed sonarqube issues in "dynamic_registry/tests/registry/__init__.py"
On Sat, Jun 19, 2021 at 11:27 AM Ashesh Vashi <[email protected]>
wrote:
> On Sat, Jun 19, 2021 at 1:39 AM Ashesh Vashi <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> We do have a couple of classes, which does automatic registration of the
>> base classes,
>> and which creates single-ton objects for these base classes, when needed.
>>
>> I would be working on a patch sooner, which will be using similar
>> functionality for loading
>> the multi-factor authentication.
>>
>> I realized - it will be a duplicate code at three places for the same
>> functionalities.
>> Hence - I worked on refactoring this registry class.
>>
>> Please find the patch for the same.
>>
> Found issues - some test files were using the old function
> 'Driver.load_drivers(...)'.
> They're fixed now.
>
> -- Thanks, Ashesh
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Refactor: Registry Classes
In-Reply-To: <CANxoLDcUuG1+yO0nGjXvZGwxnpofwyfsBNjOimSbvr40-6UPFw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox