Re: Refactor: Registry Classes

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Refactor: Registry Classes
Date: Thu, 24 Jun 2021 20:02:00 +0530
Message-ID: <CANxoLDf0TQpHbjT+bCP8y9GzH618MaNn0Z-_xGT6FyUn905eLQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELfHp1DawtMyoD83oQC74zrU+rSsc2F2evyfsgHVLmawzA@mail.gmail.com>
References: <CAG7mmoz=wOOc3QiZDZuSwonFue_sowcZRtZLK_M0o839ZPnJ_Q@mail.gmail.com>
	<CAG7mmoxQfhVhGUC2ArMkCPUoWiBusu-z6=0PR8OiZfOMQpnWwg@mail.gmail.com>
	<CANxoLDcUuG1+yO0nGjXvZGwxnpofwyfsBNjOimSbvr40-6UPFw@mail.gmail.com>
	<CAG7mmow6uPDAhfELmyXjBziHti0dE6aYCM7ufJZS3VXYZoLT-A@mail.gmail.com>
	<CANxoLDcQtnsEt-koh8dFLznyQMkaVhkF-rerW+NtzvdqPEoB=Q@mail.gmail.com>
	<CAFOhELfHp1DawtMyoD83oQC74zrU+rSsc2F2evyfsgHVLmawzA@mail.gmail.com>

Thanks, the patch applied.

On Thu, Jun 24, 2021 at 3:51 PM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> This patch introduced the server mode api test case failure, please find
> the attached patch to fix those as well as some of the old issues in the
> server mode.
> Patch by: Ashesh Vashi
>
> Thanks,
> Khushboo
>
>
> On Thu, Jun 24, 2021 at 11:31 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, the patch applied.
>>
>> On Wed, Jun 23, 2021 at 7:54 PM Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> On Wed, Jun 23, 2021 at 1:22 PM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Ashesh
>>>>
>>>> Following are the review comments:
>>>>
>>>>    - Fixed PEP8 issues.
>>>>
>>>> Done.
>>>
>>>>
>>>>    - In "dynamic_registry/__init__.py" decorator @classmethod used for
>>>>    "*_get*" and "*_load_modules*" methods which are actually outside
>>>>    of the class. Even constructor also outside of the class.
>>>>
>>>> 'create_registry_metaclass' is not a class, but a method to create the
>>> dynamic classes.
>>> If I move these methods in 'create_registry_metaclass' method, SonarQube
>>> raises issues about complexity of the functions, hence - they're best kept
>>> outside of that method.
>>>
>>>>
>>>>    - Remove unused imports from "driver/registry.py"
>>>>
>>>> Done
>>>
>>>>
>>>>    -
>>>>    - Fixed sonarqube issues in
>>>>    "dynamic_registry/tests/registry/__init__.py"
>>>>
>>>> Done
>>> As discussed, SonarQube is not able to understand that the result object
>>> is a class, and not an object, hence - showing linter issues.
>>> I've disabled them in those lines by adding the comment '# NOSNAR' at
>>> the end.
>>>
>>> -- Thanks, Ashesh
>>>
>>>>
>>>> On Sat, Jun 19, 2021 at 11:27 AM Ashesh Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> On Sat, Jun 19, 2021 at 1:39 AM Ashesh Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Akshay,
>>>>>>
>>>>>> We do have a couple of classes, which does automatic registration of
>>>>>> the base classes,
>>>>>> and which creates single-ton objects for these base classes, when
>>>>>> needed.
>>>>>>
>>>>>> I would be working on a patch sooner, which will be using similar
>>>>>> functionality for loading
>>>>>> the multi-factor authentication.
>>>>>>
>>>>>> I realized - it will be a duplicate code at three places for the same
>>>>>> functionalities.
>>>>>> Hence - I worked on refactoring this registry class.
>>>>>>
>>>>>> Please find the patch for the same.
>>>>>>
>>>>> Found issues - some test files were using the old function
>>>>> 'Driver.load_drivers(...)'.
>>>>> They're fixed now.
>>>>>
>>>>> -- Thanks, Ashesh
>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Thanks & Regards,
>>>>>>
>>>>>> Ashesh Vashi
>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>> <http://www.enterprisedb.com;
>>>>>>
>>>>>>
>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>>
>>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

view thread (7+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Refactor: Registry Classes
  In-Reply-To: <CANxoLDf0TQpHbjT+bCP8y9GzH618MaNn0Z-_xGT6FyUn905eLQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox