public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server
@ 2019-01-04 09:48 Akshay Joshi <[email protected]>
2019-01-04 13:07 ` Re: [pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server Dave Page <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Akshay Joshi @ 2019-01-04 09:48 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch to fix RM #3549 Trigger function with return type
event_trigger is not displayed in tree view with EPAS server.
Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachments:
[application/octet-stream] RM_3549.patch (3.2K, 3-RM_3549.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/coll_stats.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/coll_stats.sql
index cd8cecdf..9879f43e 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/coll_stats.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/coll_stats.sql
@@ -15,6 +15,6 @@ WHERE
pg_type typ ON typ.oid=p.prorettype
WHERE
p.prokind IN ('f', 'w')
- AND typname = 'trigger'
+ AND typname IN ('trigger', 'event_trigger')
)
ORDER BY funcname;
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/delete.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/delete.sql
index a2d698bc..f7f906b3 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/delete.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/delete.sql
@@ -12,7 +12,7 @@ JOIN
WHERE
pr.prokind IN ('f', 'w')
AND pronamespace = {{scid}}::oid
- AND typname = 'trigger'
+ AND typname IN ('trigger', 'event_trigger')
AND pr.oid = {{fnid}};
{% endif %}
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/node.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/node.sql
index 592ef754..70119f4f 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/node.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/node.sql
@@ -17,6 +17,6 @@ WHERE
{% if scid %}
AND pronamespace = {{scid}}::oid
{% endif %}
- AND typname = 'trigger' AND lanname != 'edbspl'
+ AND typname IN ('trigger', 'event_trigger') AND lanname != 'edbspl'
ORDER BY
proname;
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/properties.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/properties.sql
index 7fc529b9..7de1ef21 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/properties.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/trigger_function/ppas/sql/11_plus/properties.sql
@@ -22,7 +22,7 @@ LEFT OUTER JOIN
pg_description des ON (des.objoid=pr.oid AND des.classoid='pg_proc'::regclass)
WHERE
pr.prokind IN ('f', 'w')
- AND typname = 'trigger' AND lanname != 'edbspl'
+ AND typname IN ('trigger', 'event_trigger') AND lanname != 'edbspl'
{% if fnid %}
AND pr.oid = {{fnid}}::oid
{% else %}
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server
2019-01-04 09:48 [pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server Akshay Joshi <[email protected]>
@ 2019-01-04 13:07 ` Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2019-01-04 13:07 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
Thanks, applied.
On Fri, Jan 4, 2019 at 9:49 AM Akshay Joshi
<[email protected]> wrote:
>
> Hi Hackers,
>
> Attached is the patch to fix RM #3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server.
>
> Please review it.
>
> --
> Akshay Joshi
> Sr. Software Architect
>
>
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-01-04 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 09:48 [pgAdmin4][Patch] - RM 3549 Trigger function with return type event_trigger is not displayed in tree view with EPAS server Akshay Joshi <[email protected]>
2019-01-04 13:07 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox