public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Alessandro De Maria <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Feature 6270: Allow for --load-servers to replace current server list
Date: Fri, 26 Feb 2021 14:55:07 +0530
Message-ID: <CANxoLDcnAU67CQhdnQkAB4Bz-6MyH-M6U6LLL8TbLzTiWB1Ytw@mail.gmail.com> (raw)
In-Reply-To: <CAAivwfK6LAtYs1WsDBKmRvpzUFo_dPBWHCjNNtQBBAx0w0eSSg@mail.gmail.com>
References: <CAAivwfK6LAtYs1WsDBKmRvpzUFo_dPBWHCjNNtQBBAx0w0eSSg@mail.gmail.com>
Hi Alessandro
Patch looks good to me. Please fix the following issues:
- Fix the PEP8 issue.
- Documentation needs to be updated with this new flag. Please update
"docs-> en_Us -> import_export_servers.rst" file.
On Thu, Feb 25, 2021 at 10:06 PM Alessandro De Maria <
[email protected]> wrote:
> Hello,
>
> I have created a patch for the issue I raised earlier:
>
> https://redmine.postgresql.org/issues/6270
>
> I apologise I have never sent git patches before, and I could not find any
> specific documentation of how you expect to receive contributions.
>
> Regards
> Alessandro
>
> --
> Alessandro De Maria
> [email protected]
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Feature 6270: Allow for --load-servers to replace current server list
In-Reply-To: <CANxoLDcnAU67CQhdnQkAB4Bz-6MyH-M6U6LLL8TbLzTiWB1Ytw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox