public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Rahul Shirsat <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: SonarQube Fixes #4 Database & Foreign Tables
Date: Thu, 21 Jan 2021 14:47:15 +0530
Message-ID: <CANxoLDcnOgBoR5yc4E3ugtmF3dT71+eHJ63RPHd0OvMnf9tE-Q@mail.gmail.com> (raw)
In-Reply-To: <CAKtn9dPC12071j=ESFRBFsdKsEOtM3sZ6e3UwZj7y_hnrnyb4Q@mail.gmail.com>
References: <CAKtn9dPC12071j=ESFRBFsdKsEOtM3sZ6e3UwZj7y_hnrnyb4Q@mail.gmail.com>
Hi Rahul
Following are the review comments:
- Change the name of the function 'get_pg_db_properties'. The function
returns lastsysoid and datistemplate only and I assume it is applicable for
PG/EPAS both.
- Add comments for all the new functions introduce in the patch.
On Thu, Jan 21, 2021 at 2:36 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves the sonar qube issues
> relating:
>
>
> 1. *Foreign Tables* -*Refactor this function to reduce its Cognitive
> Complexity from 67 to the 15 allowed.*
> 2. *Database* -*Refactor this function to reduce its Cognitive
> Complexity from 17 to the 15 allowed.*
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: SonarQube Fixes #4 Database & Foreign Tables
In-Reply-To: <CANxoLDcnOgBoR5yc4E3ugtmF3dT71+eHJ63RPHd0OvMnf9tE-Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox