public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.
Date: Fri, 15 Jan 2021 11:38:48 +0530
Message-ID: <CANxoLDcq3tikv-ur1oJ-N54sfQEVtTic42bTHVm3EBBbe-PmuQ@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AMPK7rCfXLykF+1JX_+DVq31TON+G01bpzs69aPTs7QEg@mail.gmail.com>
References: <CAOBg0AMsjjfovd9tpdikhwrqYMq_v51jNyqPQFc1WofxjaDU_Q@mail.gmail.com>
	<CANxoLDdMuF+p9kHnioFgjzDwrvR+aKTzpa7EZEDSZVszrTBJ7g@mail.gmail.com>
	<CA+OCxoyghzW2OJyxC2MpyHX3=T=pSJm1s5nxG8qZO_e6Hm08SA@mail.gmail.com>
	<CANxoLDeHgFxMRBAg++3mLkGmFjDwJPKqBNz3wkhK99+rq86N8g@mail.gmail.com>
	<CAOBg0AMPK7rCfXLykF+1JX_+DVq31TON+G01bpzs69aPTs7QEg@mail.gmail.com>

Thanks, patch applied.

On Thu, Jan 14, 2021 at 5:58 PM Nikhil Mohite <
[email protected]> wrote:

> Hi Akshay,
>
> Please find the updated patch, updated UI to allow users to select an
> older date for the account expires.
>
>
> Regards,
> Nikhil Mohite.
>
> On Thu, Jan 14, 2021 at 2:52 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Nikhil
>>
>> On Thu, Jan 14, 2021 at 2:38 PM Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Thanks, patch applied.
>>>>
>>>> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Team,
>>>>>
>>>>> Please find the attached patch for RM-6120
>>>>> <https://redmine.postgresql.org/issues/6120;: Adding/updating user
>>>>> should not allow to add an older date in account expires.
>>>>> Added UI validation if a user enters the account expiration date
>>>>> manually.
>>>>>
>>>>
>>> I think this needs to be reverted (and the UI fixed to allow an older
>>> date to be selected).
>>>
>>
>>    Please fixed as suggested by Dave and send the patch. I'll update the
>> RM
>>
>>>
>>> Selecting a past expiry date is a perfectly valid way to create an
>>> account that is effectively locked, for example, to allow pre-creation of
>>> roles for staff that are yet to join.
>>>
>>> PostgreSQL doesn't prevent this - why should we?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: http://www.enterprisedb.com
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


view thread (6+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.
  In-Reply-To: <CANxoLDcq3tikv-ur1oJ-N54sfQEVtTic42bTHVm3EBBbe-PmuQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox