public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool
Date: Fri, 8 Apr 2016 20:09:20 +0530
Message-ID: <CANxoLDd0Ljz7Oq6uaJo181uiAixXHsEpDQr3nFi8VyisYx-9sQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowdBvsnin91F2chyWLaH1ivEZmD_N_oY2DEJ11jEe3OjQ@mail.gmail.com>
References: <CANxoLDe8fRZ=m8NGPc0=YQLS0vTc4-L5xmjyn2J2V1jUt937Mg@mail.gmail.com>
	<CA+OCxoz4ejTML6cjwMvOLd7vg4Dcd1koz30StnH_huND61gdzg@mail.gmail.com>
	<CANxoLDemUxkGL_z6=OPkA=3E-+ZDDmA3oht2wgDoCmurVv3JYQ@mail.gmail.com>
	<CA+OCxoxOOW4j0o+_NsV7JoW+-3aQ_As_xC90U3ShGw_DgWgLvQ@mail.gmail.com>
	<CANxoLDcp=sjd=P8U7qUP3tOQThAXDx+GUFyoE6F9xNDKwa5MnA@mail.gmail.com>
	<CA+OCxozK661Ha4RD51FtxmEdTzBd2h0nVgemAhfh0opbYOTerA@mail.gmail.com>
	<CANxoLDcxkQ+T8XwpVabDo2=E5P0x3e27Gz4Ob3NAsi_9C=m14w@mail.gmail.com>
	<CA+OCxowdBvsnin91F2chyWLaH1ivEZmD_N_oY2DEJ11jEe3OjQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Dave

On Fri, Apr 8, 2016 at 2:32 PM, Dave Page <[email protected]> wrote:

>
>
> On Fri, Apr 8, 2016 at 7:43 AM, Akshay Joshi <
> [email protected]> wrote:
>>
>>
>>>>>>> - The Query Tool menu icon should be a glyphicon, to match the
>>>>>>> others.
>>>>>>>
>>>>>>
>>>>>>    There is no glyphicon available which match the Query Tool icon.
>>>>>> I have found one like below which is "database-search" or can you please
>>>>>> suggest some other icon.
>>>>>>        [image: Inline image 1]
>>>>>>
>>>>>
>>>>> That one looks perfect.
>>>>>
>>>>
>>            We can't use this icon because it's not come with Bootstrap ,
>> I have picked this from "http://glyphicons.com/"; and I am not sure we
>> can use it as per the Licence.
>>
>
> At the risk of annoying everyone immensely, on reflection I'm thinking we
> should use Font Awesome as our default generic icons, and fall back to
> Bootstrap's Glyphicons. I really hadn't realised how much larger the FA set
> is.
>
> For this particular issue, could we use FA's stacking? e.g. something
> like: https://jsfiddle.net/pa8x6nt3/
>
> If not, how about using the execute icon we discussed, e.g. fa-bolt?
>

   I have used fa-bolt. Apart from that I have completed below review
comments


   - The View Data menu option should be on the Object menu, which should
   mirror the Context menu, except options should be disabled when not
   applicable instead of hidden. *Note*: - With current implementation
   "Object" menu is re-created dynamically depending on the node clicked, so
   we will have to re-create the "View Data" menu as well and it require
   change in the generic code. For the time being "View Data" menu is visible
   in "Object" menu when appropriate node is selected.
   - Please merge the functionality of the Refresh and Execute buttons into
   one button. We shouldn't have two buttons that do essentially the same
   thing.
   - In Edit Grid mode, that textbox should be read-only, but should
   display the SQL used (including any LIMIT/FILTER clauses). Please refer
   the attached screenshot (Modified-Data-Grid).
   - Please adjust the height of the Delete icon in the Edit Grid, such
   that it doesn't force the row height to be higher than it should be.
   - I think the names of the tabs are far too long. Can we change them to
   "Query 1", "Query 2" etc, then rename them to the filename if the user
   saves/loads a file? *Note*: - As discussed I have added one
   more container to show the title. Please refer the attached screenshots
   (Modified-Query-Tool)
   - Query results should have spaces converted to "&nbsp;", so that proper
   indenting is maintained (for example, on EXPLAIN queries)
   - To fix this we have added css style "*white-space: pre-wrap;*", but it
      changes the backgrid cell size. Please refer the screenshot
      (Modified-Data-Grid).

   Please review the screenshots and please let me know will it looks good.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [image/png] image.png (2.4K, 3-image.png)
  download | view image

  [image/png] Modified-Data-Grid.png (175.1K, 4-Modified-Data-Grid.png)
  download | view image

  [image/png] Modified-Query-Tool.png (195.0K, 5-Modified-Query-Tool.png)
  download | view image

view thread (18+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4] [Patch] Implementation of the Data Grid and Query Tool
  In-Reply-To: <CANxoLDd0Ljz7Oq6uaJo181uiAixXHsEpDQr3nFi8VyisYx-9sQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox