public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM4232]: Change what is shown by default in tab titles
Date: Tue, 20 Oct 2020 17:18:29 +0530
Message-ID: <CANxoLDdKqwWeBgZZdVcPO=Waz9J-bWnphzDqUzhf3bihLJcW1g@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AOHsocS1BObY6_umWc7VUdDhE0EFDzQv3b7Ng=Ui7EpQA@mail.gmail.com>
References: <CAOBg0APaeJgs+=r5iS8tVEXYQ_j2sGi4pK4Z5G=rTT9bWPcA+w@mail.gmail.com>
<CANxoLDcq=uXy+XSP4-X50x4K=AZtibdm11vhwnEoD7oPAqcGug@mail.gmail.com>
<CAOBg0AOHsocS1BObY6_umWc7VUdDhE0EFDzQv3b7Ng=Ui7EpQA@mail.gmail.com>
Thanks, patch applied.
On Tue, Oct 20, 2020 at 9:07 AM Nikhil Mohite <
[email protected]> wrote:
> Hi Akshay,
>
> I have resolved the review comments and also added a %ARGS% placeholder
> for the debugger.
> PFA patch v2.
>
> Regards,
> Nikhil Mohite.
>
> On Mon, Oct 19, 2020 at 10:58 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Nikhil
>>
>> Following are the review comments:
>>
>> - Jasmin test cases are failing.
>> - Can we change the following strings in preferences:
>> - "Query tool tab title placeholder" to "Query tool tab title"
>> - "View/Edit tab title placeholder" to "View/Edit data tab title"
>> - "Debugger tab title placeholder" to "Tab title" as this setting
>> is already inside the Debugger section.
>> - Change the help messages in the preferences dialog to:
>> - "*Supported placeholders are %DATABASE%, %USERNAME%, and
>> %SERVER%. Users can provide any string with or without placeholders of
>> their choice. The blank title will be revert back to the default title with
>> placeholders.*" (Make the same changes for Query tool, View/Edit,
>> and Debugger tab title message)
>> - For Debugger can we add %ARGS% because in the case of functions
>> with arguments tab title is very long, so the user should have the option
>> to discard arguments in the tab title.
>>
>> Update the documentation if you will make the above changes.
>>
>> On Tue, Oct 13, 2020 at 5:27 PM Nikhil Mohite <
>> [email protected]> wrote:
>>
>>> Hi Team,
>>>
>>> Regarding RM-4232 <https://redmine.postgresql.org/issues/4232; Change
>>> what is shown by default:
>>> Added placeholders in preferences as following:
>>> 1. Debugger: Added placeholder in the display section of the debugger.
>>> 2. Query Tool and View/Edit data: Added placeholder in the display
>>> section of the Query Tool.
>>>
>>> Updated the documentation for Query Tool and Debugger with new
>>> screenshots.
>>>
>>> PFA patch.
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][RM4232]: Change what is shown by default in tab titles
In-Reply-To: <CANxoLDdKqwWeBgZZdVcPO=Waz9J-bWnphzDqUzhf3bihLJcW1g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox