public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab
Date: Mon, 21 Sep 2020 17:24:06 +0530
Message-ID: <CANxoLDdUj_RKgQWFE6F7noEJbDz+P_3-njnn2mf10TSa0V9wdw@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AM=b7hfJjTJAXu=wGkKHEsV_zoZpSO-QU6Z-G9p2wVF0w@mail.gmail.com>
References: <CAOBg0AM=b7hfJjTJAXu=wGkKHEsV_zoZpSO-QU6Z-G9p2wVF0w@mail.gmail.com>

Hi Nikhil

Following are the initial review comments:

   - Open View/Edit data on any table and click on the same database
   connection and then click on the Execute button. Got "get_primary_keys()
   takes 1 positional argument but 2 were given" error.
   - In my opinion, we should hide the option to change the database
   connection for View/Edit Data.
   - If the user clicks on the same database connection multiple times then
   no need to change the backend connection and transaction id. Add validation
   at the backend, no action required in this case.
   - The role option is missing from the "connect to server" dialog.
   - The Password field should not be there on the "connect to server"
   dialog. Sometimes we saved the password so asking a password every time is
   not correct. Check the pgAdmin 3 behavior.

Code review still remains.

On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <
[email protected]> wrote:

> Hi Team,
>
> Regarding RM-3794 <https://redmine.postgresql.org/issues/3794; allow
> the user to change the database connection from an open query tool:
> I have implemented the feature and also added documentation for it.
>
> PFA patch.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


view thread (18+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab
  In-Reply-To: <CANxoLDdUj_RKgQWFE6F7noEJbDz+P_3-njnn2mf10TSa0V9wdw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox