public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Pradip Parkale <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-7132]: Port Properties collection, Dashboard and SQL panel in React
Date: Wed, 30 Mar 2022 12:08:00 +0530
Message-ID: <CANxoLDdqFBoXw2jpQv7YseXHfzbzpG6WrStb+qn89HhVA=S3Gg@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6SsN6MHBv85L2GxNrrNc38XmkezpV8uUSXXYwQs5c9B1Sw@mail.gmail.com>
References: <CAJ9T6SsL-tzYYchh2KghWkHTY6y4L0=qCJ9VoGVCuu1WyT-0vQ@mail.gmail.com>
<CANxoLDdOUwHyUJ=-pDS94B9nX+5pRw3vZDQfMxHR-dH3d4c0CA@mail.gmail.com>
<CAM9w-_mnm_gk_03xONOCY7WaXmQMnww1NieuO4-KmvaFFPQRGA@mail.gmail.com>
<CAJ9T6StZWvdd1xkodyD3nLEL4ye+Z=sXQP06wzp7fc=DsX19dQ@mail.gmail.com>
<CAJ9T6Svt7hdfC5R444NdF_taL-2tQipVoMm1MuhvTus+rgopFA@mail.gmail.com>
<CAJ9T6SvZFeiXXfDn=Tp7tb9USiSFCZje0q3txjwrgSb6pPL_WA@mail.gmail.com>
<CANxoLDce0k6o-pg-2vZHwEwTSzJ89-cwG1gE=ce9QpnRFo5iJg@mail.gmail.com>
<CAJ9T6SsN6MHBv85L2GxNrrNc38XmkezpV8uUSXXYwQs5c9B1Sw@mail.gmail.com>
Thanks, the patch applied.
On Wed, Mar 30, 2022 at 11:31 AM Pradip Parkale <
[email protected]> wrote:
> Hi Akhay,
>
> Please find the updated patch.I have fixed all the issues.
>
> On Mon, Mar 28, 2022 at 11:58 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Pradip
>>
>> Following are the review comments (GUI):
>>
>> - Catalog objects should not be drop or drop cascade. Remove
>> checkboxes from the properties panel.
>> - Database column should be there for the 'Server Activity' table
>> all tabs when the server is selected. When the database is selected it
>> should be hidden.
>> - Rename 'Lock' tab to 'Locks'.
>> - Remove extra column 'Waiting' which was not there originally.
>> - 'Server Activity' -> Sessions-> Details for the last record is not
>> readable. Fix the scroll bar issue. Same with the Configuration tab last
>> 4-5 records are not readable.
>> - Select and expand the first and second records, the rest of the
>> records are not visible, again seems to be a scroll bar issue.
>> - 'Server Activity' -> Locks, "Granted?" column is empty, not showing
>> any value.
>> - Set the width of the column appropriately for all the tabs, for
>> example, unit columns (in Configuration tab) width should be less, so that
>> data on the other columns are more readable. Check all the tabs and set
>> them appropriately
>> - Faced "Request failed with status code 404" error. Select database
>> server from browser tree and then select 'Server Activity'
>> -> Configuration. Now select any database, you will get the error.
>> - Properties panel size of the column having checkboxes should be
>> less, compare with existing behavior.
>> - Properties panel should show the message '*No Properties are
>> available for the selected object*' if the respective collection node
>> does not have children.
>>
>>
>>
>> On Mon, Mar 28, 2022 at 10:08 AM Pradip Parkale <
>> [email protected]> wrote:
>>
>>> Hi,
>>> Here is the updated patch. This patch includes the fix for #7215
>>> <https://redmine.postgresql.org/issues/7215;.
>>>
>>> On Mon, Mar 28, 2022 at 9:11 AM Pradip Parkale <
>>> [email protected]> wrote:
>>>
>>>> Hi Aditya,
>>>> Please ignore the previous email, find the updated patch attached.
>>>>
>>>> On Sun, Mar 27, 2022 at 11:07 PM Pradip Parkale <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Aditya,
>>>>> Please find the updated patch.
>>>>>
>>>>> On Tue, Mar 15, 2022 at 5:40 PM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Pradip,
>>>>>>
>>>>>> I did some basic usage and review and found below issues:
>>>>>> 1. The code fails if you refresh the page and go to properties, when
>>>>>> no node is selected.
>>>>>> 2. I found below UI issues on selecting a database node. Also,
>>>>>> checkbox column is too wide.
>>>>>> [image: image.png]
>>>>>> 3. Why is this in the node.js file. It should be in node_view.jsx.
>>>>>>
>>>>>> +
>>>>>>
>>>>>> + ReactDOM.render(
>>>>>>
>>>>>> + <Theme>
>>>>>>
>>>>>> + <CollectionNodeView
>>>>>>
>>>>>> + node={node}
>>>>>>
>>>>>> + treeNodeInfo={treeNodeInfo}
>>>>>>
>>>>>> + item={item}
>>>>>>
>>>>>> + itemNodeData={d}
>>>>>>
>>>>>> + pgBrowser={pgBrowser}
>>>>>>
>>>>>> + ></CollectionNodeView>
>>>>>>
>>>>>> + </Theme>,
>>>>>>
>>>>>> + b.panels['properties'].panel.$container[0]
>>>>>>
>>>>>> + );
>>>>>>
>>>>>> 4. I have seen a lot of commented codes. Few samples:
>>>>>>
>>>>>> + // if (that.canHide) {
>>>>>>
>>>>>>
>>>>>> + //
>>>>>> pgBrowser.Events.off('pgadmin-browser:tree:selected', () => {
>>>>>>
>>>>>> +
>>>>>>
>>>>>> + // removePanelView($container[0]);
>>>>>>
>>>>>> + // });
>>>>>>
>>>>>> 5. In WelcomeDashboard.jsx, the complete SVG code is put. Please move
>>>>>> it to a file and import it.
>>>>>> 6. Cleanup web/pgadmin/dashboard/static/js/dashboardDummy.js
>>>>>> 7. Cleanup web/pgadmin/dashboard/static/js/dashboard_ponents.jsx
>>>>>> 8. Rename Sql.jsx to SQL.jsx
>>>>>> 9. The search is not working. It filters all.
>>>>>> 10. If there is huge data then it should show some spinner.
>>>>>> 11. Delete buttons should be disabled if no object is selected.
>>>>>> 12. Delete buttons and search box should be on the same line.
>>>>>>
>>>>>> On Tue, Mar 15, 2022 at 4:01 PM Akshay Joshi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Aditya
>>>>>>>
>>>>>>> Can you please review/test it?
>>>>>>>
>>>>>>> On Mon, Mar 14, 2022 at 7:17 PM Pradip Parkale <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Hackers,
>>>>>>>>
>>>>>>>> Please find the attached patch for #7132
>>>>>>>> <https://redmine.postgresql.org/issues/7132; Port Properties
>>>>>>>> collection, Dashboard and SQL panel in React.
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Thanks & Regards,
>>>>>>>> Pradip Parkale
>>>>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Thanks & Regards*
>>>>>>> *Akshay Joshi*
>>>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>>>
>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>>>>> <http://edbpostgres.com;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanks & Regards,
>>>>> Pradip Parkale
>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> Software Engineer | EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] image.png (249.1K, 3-image.png)
download | view image
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM-7132]: Port Properties collection, Dashboard and SQL panel in React
In-Reply-To: <CANxoLDdqFBoXw2jpQv7YseXHfzbzpG6WrStb+qn89HhVA=S3Gg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox