public inbox for [email protected]
help / color / mirror / Atom feed[Patch] - AWS Cloud Deployment fixes
2+ messages / 2 participants
[nested] [flat]
* [Patch] - AWS Cloud Deployment fixes
@ 2022-03-03 13:33 Yogesh Mahajan <[email protected]>
2022-03-04 05:44 ` Re: [Patch] - AWS Cloud Deployment fixes Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Yogesh Mahajan @ 2022-03-03 13:33 UTC (permalink / raw)
To: pgadmin-hackers; +Cc: Khushboo Vashi <[email protected]>
Hi,
Please find the attached patch to fix the below issues in AWS cloud
deployment:
1.Console error logged for db version 9.6.1 due to boto3 version update
2.Unmask Access Key field
3.Update supported DB version list to postgres 10 & 10+.
Thanks,
Yogesh Mahajan
EnterpriseDB
Attachments:
[application/octet-stream] cloud_deployment_fixes_v1.patch (1.8K, 3-cloud_deployment_fixes_v1.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/cloud/static/js/cloud_db_details_schema.ui.js b/web/pgadmin/misc/cloud/static/js/cloud_db_details_schema.ui.js
index 593deb601..f26a6c199 100644
--- a/web/pgadmin/misc/cloud/static/js/cloud_db_details_schema.ui.js
+++ b/web/pgadmin/misc/cloud/static/js/cloud_db_details_schema.ui.js
@@ -88,7 +88,7 @@ class CloudDBCredSchema extends BaseUISchema {
noEmpty: true,
helpMessage: gettext('The cloud instance will be deployed in the selected region.')
},{
- id: 'aws_access_key', label: gettext('AWS access key'), type: 'password',
+ id: 'aws_access_key', label: gettext('AWS access key'), type: 'text',
mode: ['create'], noEmpty: true,
}, {
id: 'aws_secret_access_key', label: gettext('AWS secret access key'), type: 'password',
diff --git a/web/pgadmin/misc/cloud/utils/rds.py b/web/pgadmin/misc/cloud/utils/rds.py
index 177e0aaae..9c32cbbf1 100644
--- a/web/pgadmin/misc/cloud/utils/rds.py
+++ b/web/pgadmin/misc/cloud/utils/rds.py
@@ -122,7 +122,7 @@ def get_aws_db_instances(eng_version):
return False, 'Session has not created yet.'
if not eng_version or eng_version == '' or eng_version == 'undefined':
- eng_version = '9.6.1'
+ eng_version = '10.17'
rds_obj = pickle.loads(session['aws']['aws_rds_obj'])
res = rds_obj.get_available_db_instance_class(
@@ -148,7 +148,8 @@ def get_aws_db_versions():
rds_obj = pickle.loads(session['aws']['aws_rds_obj'])
db_versions = rds_obj.get_available_db_version()
- res = db_versions['DBEngineVersions']
+ res = list(filter(lambda val: not val['EngineVersion'].startswith('9.6'),
+ db_versions['DBEngineVersions']))
versions = []
for value in res:
versions.append({
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [Patch] - AWS Cloud Deployment fixes
2022-03-03 13:33 [Patch] - AWS Cloud Deployment fixes Yogesh Mahajan <[email protected]>
@ 2022-03-04 05:44 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2022-03-04 05:44 UTC (permalink / raw)
To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers; Khushboo Vashi <[email protected]>
Thanks, the patch applied.
On Thu, Mar 3, 2022 at 7:04 PM Yogesh Mahajan <
[email protected]> wrote:
> Hi,
>
> Please find the attached patch to fix the below issues in AWS cloud
> deployment:
>
> 1.Console error logged for db version 9.6.1 due to boto3 version update
> 2.Unmask Access Key field
> 3.Update supported DB version list to postgres 10 & 10+.
>
> Thanks,
> Yogesh Mahajan
> EnterpriseDB
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-03-04 05:44 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 13:33 [Patch] - AWS Cloud Deployment fixes Yogesh Mahajan <[email protected]>
2022-03-04 05:44 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox