public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions
Date: Tue, 22 Sep 2020 17:02:29 +0530
Message-ID: <CANxoLDduK0isJUAwFkp84jthXn7R9Tb_-y2E_u5TNxRCTCVV-g@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AN==k1y7fj=LDOzBj2pbbBg1vwM3qWtf9kNxgKBKjhHmg@mail.gmail.com>
References: <CAOBg0AMPMqnuORm9Qj3un7MKBf9CM4EYZFMF1q_yrHR4pVK0dA@mail.gmail.com>
	<CANxoLDevEYsKrtRPTrYhgqAdPi69sFyQaFbW9e8ZyF-cBOs-4A@mail.gmail.com>
	<CAOBg0AN==k1y7fj=LDOzBj2pbbBg1vwM3qWtf9kNxgKBKjhHmg@mail.gmail.com>

Thanks, patch applied

On Tue, 22 Sep, 2020, 12:44 Nikhil Mohite, <[email protected]>
wrote:

> Hi Akshay/Team,
>
> I checked the code and found an issue in the "msql" function, due to which
> test cases were failing.
> I have fixed the issue, PFA updated patch for the same.
> Sorry for the inconvenience.
>
>
> Regards,
> Nikhil Mohite.
>
>
>
> On Tue, Sep 22, 2020 at 11:41 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Nikhil
>>
>> Test cases are failing for all the database server with the following
>> error:
>>     return True, sql.strip('\n')
>> AttributeError: 'tuple' object has no attribute 'strip'
>>
>> Please check and resend the patch.
>>
>> On Tue, Sep 22, 2020 at 10:56 AM Nikhil Mohite <
>> [email protected]> wrote:
>>
>>> Hi Team,
>>>
>>> I have added few more test cases for the "Functions" module as per
>>> RM-5330 <https://redmine.postgresql.org/issues/5330;
>>> PFA patch.
>>>
>>> --
>>> *Thanks & Regards,*
>>> *Nikhil Mohite*
>>> *Software Engineer.*
>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>> *Mob.No: +91-7798364578.*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>


view thread (15+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions
  In-Reply-To: <CANxoLDduK0isJUAwFkp84jthXn7R9Tb_-y2E_u5TNxRCTCVV-g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox