public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Rahul Shirsat <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [Patch][pgAdmin] RM4203 Rename Database by another user
Date: Thu, 27 May 2021 12:19:31 +0530
Message-ID: <CANxoLDdvQGWZT7DbmMmssLxy3biY+--KeQx40AkTXzmp7kizLg@mail.gmail.com> (raw)
In-Reply-To: <CAKtn9dPZQWV8aT+mW5DRU3dZYwKyKyanGST7-juuEdV4Dhp1AA@mail.gmail.com>
References: <CAKtn9dPZQWV8aT+mW5DRU3dZYwKyKyanGST7-juuEdV4Dhp1AA@mail.gmail.com>

Hi Rahul

Following are the review comments:

   - Why you have changed the order of the toolbar button on the browser
   tree? It should not.
   - *sqleditor.js (check_db_name_change function)*
   - var declaration should be comma-separated instead of writing var,
      again and again.
      - Add proper comments.
      - Remove dots from the string "Database moved/renamed.."
      - "Please note that the database you are working on has been moved or
      renamed to ${data.actual_db_name}. Refresh databases in browser panel or
      click OK to continue.." should be changed to "Current database has been
      moved or renamed to ${data.actual_db_name}. Click on the OK button to
      refresh the database name."



On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <
[email protected]> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issue of renaming the
> database by another user.
>
> A minor issue of navigation button alignment is also fixed in this patch.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


view thread (6+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [Patch][pgAdmin] RM4203 Rename Database by another user
  In-Reply-To: <CANxoLDdvQGWZT7DbmMmssLxy3biY+--KeQx40AkTXzmp7kizLg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox