public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
Date: Fri, 10 Apr 2020 14:55:30 +0530
Message-ID: <CANxoLDdwKLoP6E97+Nv68b+G1jmV0XfKUffTEHpo9e+=dD2PMw@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELeQiDhuATRuzxaXGUsbrabiPX23MKx0x2NtJEmD_QkCvg@mail.gmail.com>
References: <CAFOhELcnGqr-498VPibJitLEAW0zcanyV5s5y4wUMSn4xs2hgA@mail.gmail.com>
	<CANxoLDf-Mpra5+7QRZk+Y9OX95nqn0jjQ-Dkcn4EdB4duBbfrg@mail.gmail.com>
	<CAFOhELcDBAsZ=sM7HGW_nh3KfSBXRbJb2SpzvF-0Za31JNKq+w@mail.gmail.com>
	<CAFOhELeQiDhuATRuzxaXGUsbrabiPX23MKx0x2NtJEmD_QkCvg@mail.gmail.com>

Thanks patch applied.

On Fri, Apr 10, 2020 at 11:58 AM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Khushboo
>>>
>>> Schema Diff test cases are failing with this patch. Please fix and
>>> resend the patch.
>>>
>>> Fixed.
>
> Thanks,
> Khushboo
>
>> Can you please re-verify as I don't think schema diff test cases are
>> failing due to this patch.
>>
>> Thanks,
>> Khushboo
>>
>>> On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym
>>>> properties does not show OID.
>>>>
>>>> As per the current implementation, we completely ignored OID and
>>>> instead considered the name as the unique field, now with this patch OID
>>>> will be used as an unique id and also will display OID in the properties
>>>> tab.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
  In-Reply-To: <CANxoLDdwKLoP6E97+Nv68b+G1jmV0XfKUffTEHpo9e+=dD2PMw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox