public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language
@ 2021-02-25 12:43 Rahul Shirsat <[email protected]>
2021-02-26 07:53 ` Re: [pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Shirsat @ 2021-02-25 12:43 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the attached patch which resolves the issue of save button
getting enabled for procedure, additionally for functions as well.
There is no support for Estimated cost in Procedure for PG, which is also
taken care of in this fix.
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM5073.patch (1.7K, 3-RM5073.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js
index 6bda73d4e..2420fcf2f 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/function.js
@@ -179,7 +179,7 @@ define('pgadmin.node.function', [
proiswindow: undefined, /* Window Function ? */
proparallel: undefined, /* Parallel mode */
procost: undefined, /* Estimated execution Cost */
- prorows: undefined, /* Estimated number of rows */
+ prorows: 0, /* Estimated number of rows */
proleakproof: undefined,
prosupportfunc: undefined, /* Support function */
arguments: [],
@@ -306,7 +306,7 @@ define('pgadmin.node.function', [
select2: {allowClear: false},
},{
id: 'procost', label: gettext('Estimated cost'), group: gettext('Options'),
- cell:'string', type: 'text', readonly: 'isReadonly', deps: ['lanname'],
+ cell:'string', type: 'text', readonly: 'isReadonly', deps: ['lanname'], disabled: 'isDisabled',
},{
id: 'prorows', label: gettext('Estimated rows'), type: 'text',
deps: ['proretset'], visible: 'isVisible', readonly: 'isReadonly',
@@ -462,9 +462,6 @@ define('pgadmin.node.function', [
if(m.get('proretset') == true) {
return false;
}
- setTimeout(function() {
- m.set('prorows', 0);
- }, 10);
return true;
default:
return false;
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language
2021-02-25 12:43 [pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language Rahul Shirsat <[email protected]>
@ 2021-02-26 07:53 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2021-02-26 07:53 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Thu, Feb 25, 2021 at 6:14 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the attached patch which resolves the issue of save button
> getting enabled for procedure, additionally for functions as well.
>
> There is no support for Estimated cost in Procedure for PG, which is also
> taken care of in this fix.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-02-26 07:53 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-25 12:43 [pgAdmin] RM5073 Save button is enabled in properties of Procedure by-default for SQL language Rahul Shirsat <[email protected]>
2021-02-26 07:53 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox