public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React
Date: Wed, 17 Nov 2021 18:34:32 +0530
Message-ID: <CANxoLDe5mEx_pM85YarO_qeSa+_wOvThOuvPbtMfA3_3b4XhKw@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AP5qPSeQTszGraKxJ9DLt5-Qd7ikuU8oa1OJTpnmX4MPA@mail.gmail.com>
References: <CAOBg0AP5qPSeQTszGraKxJ9DLt5-Qd7ikuU8oa1OJTpnmX4MPA@mail.gmail.com>

Hi Nikhil

Following are the review comments:

GUI:

   - Dialog size should be increased.
   - Remove the first blank element from the Encoding dropdown.
   - When opening the file dialog header should have the title 'Select
   file'.
   - 'Backup server' title should be changed to 'Backup Server'.
   - When taking the backup of any object like database, schema, etc..
   the title on the dialog header should be "Backup (Database/Schema ..."
   instead of  "Backup (database/schema ..."


Code:

   - Jasmine test cases are failing.
   - Remove warnBeforeChangesLost function not needed for Utilities.
   (Remove Alertify as well)
   - The naming convention should be identical, in some cases, you used
   camel case and in some cases used with an underscore.
   - Remove the commented code from all the files.
   - Take all the screenshots again with a width of 681.

Note: I haven't tested it thoroughly with all combinations.

On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite <
[email protected]> wrote:

> Hi Hackers,
>
> Please find the attached patch for RM-6884:
> <https://redmine.postgresql.org/issues/6984;  Port Backup Global, Backup
> Server, and Backup object dialog in React
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Senior Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React
  In-Reply-To: <CANxoLDe5mEx_pM85YarO_qeSa+_wOvThOuvPbtMfA3_3b4XhKw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox