public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM6207] Update JS dependencies
Date: Tue, 9 Feb 2021 16:34:56 +0530
Message-ID: <CANxoLDeAACqnFHf=kRxXSej5VdnvoUziZON27LTjVQnDdPcHWw@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_kn5C3YBQW9F2cOHgHq=DprNEi1eN-JL2Cfkdc-auUDuw@mail.gmail.com>
References: <CAM9w-_kn5C3YBQW9F2cOHgHq=DprNEi1eN-JL2Cfkdc-auUDuw@mail.gmail.com>

Hi Aditya

One jasmine test is failing, please fix that and resend the patch.

On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the patch to update the JS dependencies to latest. Changes
> include:
> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking
> changes, so updated multiple webpack plugins and changed the config
> accordingly.
> 2) Replaced iconfont-webpack-plugin with a more maintained
>  webfonts-loader.
> 3)  Replaced deprecated babel-eslint with @babel/eslint-parser
> 4)  Replaced optimize-css-assets-webpack-plugin with a more maintained
> css-minimizer-webpack-plugin
> 5) Updated all other JS packages and made the required code changes.
>
> Note, there is an update available for slickgrid and I tried to update it.
> But it was not working as expected. So without wasting time, I've not
> updated slickgrid, and can be updated as a separate task.
>
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM6207] Update JS dependencies
  In-Reply-To: <CANxoLDeAACqnFHf=kRxXSej5VdnvoUziZON27LTjVQnDdPcHWw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox