public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Pradip Parkale <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][SonarQube] : Remove duplicates string literals.
Date: Mon, 7 Sep 2020 18:48:24 +0530
Message-ID: <CANxoLDeCsGLw_Au3o0E86OyyOY=qowNQVbFw2acR50V6b_55EQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6Ss3trXEnFPTwi+BV0JGLjxN8-D3YsjtsnE7-MFSzN0_EA@mail.gmail.com>
References: <CAJ9T6SvWCLEOctFXnynEefeo-df40RoE-m6JjCqjvOPXzJ01fg@mail.gmail.com>
	<CANxoLDduNdt4Uyz-mxUHMLhVd9jKzmKvUNmWg4m0nzjwQq4j8w@mail.gmail.com>
	<CAJ9T6Ss3trXEnFPTwi+BV0JGLjxN8-D3YsjtsnE7-MFSzN0_EA@mail.gmail.com>

Thanks, patch applied.

On Thu, Sep 3, 2020 at 7:19 PM Pradip Parkale <
[email protected]> wrote:

> Hi Akshay,
>
> Please find the updated patch.
>
>
> On Thu, Sep 3, 2020 at 6:24 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Hi Pradip
>>
>> Following are the review comments:
>>
>>    - ROLE_NOT_FOUND already in wrapped in gettext() then no need to use
>>    like gone(_(ROLE_NOT_FOUND)). In fact, can we use
>>
>>    self.not_found_error_msg()instead of new constant.
>>
>>    - Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext,
>>    also we can use this constant for string "
>>
>>    Error retrieving roles from the database server"
>>
>>
>>
>> On Thu, Sep 3, 2020 at 4:30 PM Pradip Parkale <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a patch for removing duplicates string literals.
>>>         /server_groups/servers/roles/__init__.py  - 8 places
>>>
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


view thread (4+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][SonarQube] : Remove duplicates string literals.
  In-Reply-To: <CANxoLDeCsGLw_Au3o0E86OyyOY=qowNQVbFw2acR50V6b_55EQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox