public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11) 3+ messages / 3 participants [nested] [flat]
* [pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11) @ 2019-07-24 08:56 Ganesh Jaybhay <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Ganesh Jaybhay @ 2019-07-24 08:56 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Attached is the minor fix to highlight adjacent switch cell on focus in IE11. Currently nn create table columns tab, on navigating from Not Null? to Primary key? column, switch cell for primary key doesn't get highlighted. Kindly review. Regards, Ganesh Jaybhay Attachments: [application/octet-stream] adjacent_switch_focus.patch (1.4K, 3-adjacent_switch_focus.patch) download | inline diff: diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js index 8275138..3f756ae 100644 --- a/web/pgadmin/static/js/backgrid.pgadmin.js +++ b/web/pgadmin/static/js/backgrid.pgadmin.js @@ -690,7 +690,7 @@ define([ this.$el.append( $('<input>', { - tabIndex: -1, + tabIndex: 0, type: 'checkbox', }).prop('checked', rawValue).prop('disabled', !editable).attr('data-toggle', 'toggle') .attr('data-size', options.size).attr('data-on', options.onText).attr('data-off', options.offText) @@ -726,13 +726,17 @@ define([ } else if (gotoCell.hasClass('editable')) { e.preventDefault(); e.stopPropagation(); - self.model.trigger('backgrid:edited', self.model, - self.column, command); + setTimeout(function() { + self.model.trigger('backgrid:edited', self.model, + self.column, command); + }, 100); gotoCell.trigger('focus'); } else { // When we have Non-Editable Cell - self.model.trigger('backgrid:edited', self.model, - self.column, command); + setTimeout(function() { + self.model.trigger('backgrid:edited', self.model, + self.column, command); + }, 100); } }, 20); } ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11) @ 2019-07-25 15:55 Dave Page <[email protected]> parent: Ganesh Jaybhay <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Dave Page @ 2019-07-25 15:55 UTC (permalink / raw) To: Ganesh Jaybhay <[email protected]>; +Cc: pgadmin-hackers Hi, What's the RM number for this please? On Thu, Jul 25, 2019 at 4:49 PM Ganesh Jaybhay < [email protected]> wrote: > Hi Hackers, > > Attached is the minor fix to highlight adjacent switch cell on focus in > IE11. > > Currently nn create table columns tab, on navigating from Not Null? to > Primary key? column, switch cell for primary key doesn't get highlighted. > > Kindly review. > > Regards, > Ganesh Jaybhay > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11) @ 2019-07-26 02:21 Akshay Joshi <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Akshay Joshi @ 2019-07-26 02:21 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Ganesh Jaybhay <[email protected]>; pgadmin-hackers Hi Dave Yesterday I have committed this patch, as email was held for moderation. Ganesh has send the patch to me directly. On Thu, 25 Jul, 2019, 21:25 Dave Page, <[email protected]> wrote: > Hi, > > What's the RM number for this please? > > On Thu, Jul 25, 2019 at 4:49 PM Ganesh Jaybhay < > [email protected]> wrote: > >> Hi Hackers, >> >> Attached is the minor fix to highlight adjacent switch cell on focus in >> IE11. >> >> Currently nn create table columns tab, on navigating from Not Null? to >> Primary key? column, switch cell for primary key doesn't get highlighted. >> >> Kindly review. >> >> Regards, >> Ganesh Jaybhay >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-07-26 02:21 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-07-24 08:56 [pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11) Ganesh Jaybhay <[email protected]> 2019-07-25 15:55 ` Dave Page <[email protected]> 2019-07-26 02:21 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox