Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs
Date: Tue, 29 Jun 2021 14:39:06 +0530
Message-ID: <CANxoLDeKHvKmFvfywm2xxfgu7k0kHKV7Ba8M5AGTR71rf9r7pA@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_k3ik+MBiYxbQTMMR=hWCqsHTvX7=LZLGVZkTF9t2U3+w@mail.gmail.com>
References: <CAM9w-_=RbH2Nt9cWRf5ZaE509-a2nxvDxdNYN=BakLGvM288Lg@mail.gmail.com>
	<CA+OCxoxSOEBPErd-FXTHLi6gpVbo3TzkVQcZwzMg9P3+Cmnj6w@mail.gmail.com>
	<CAM9w-_=FJqY-kJkEDzq7vXmBVv0SdbWe=Gkq2qBL9mbxYyA8pw@mail.gmail.com>
	<CANxoLDexFZ4=EMO-r45RAJwopo-k54o6+QYr08H=KziEAm11dQ@mail.gmail.com>
	<CAM9w-_=UjoitLEooheh5yF3vvZHdoSv4hMpD0z3Ge9g0ri1cwQ@mail.gmail.com>
	<CAM9w-_k3ik+MBiYxbQTMMR=hWCqsHTvX7=LZLGVZkTF9t2U3+w@mail.gmail.com>

Thanks, the patch applied.

On Mon, Jun 28, 2021 at 3:57 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Please ignore the previous patch. Attached is the revised patch.
>
> On Mon, Jun 28, 2021 at 2:50 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> I made some changes to the core code that will be helpful for other nodes.
>> Please review.
>>
>>
>> On Thu, Jun 24, 2021 at 5:39 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, the patch applied in the "React_Porting" branch.
>>>
>>> On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> On Thu, Jun 17, 2021 at 7:26 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached patch marks the beginning of migrating properties dialog/tab
>>>>>> to React based code, which is easy to maintain, performant and testable
>>>>>> using automation.
>>>>>> Patch includes:
>>>>>> - Framework for creating React based dynamic form view out of a
>>>>>> pre-defined UI schema. Previously, it was based on Backform/Backbone.
>>>>>> - The new framework and components will use MaterialUI as base.
>>>>>> Previously, Bootstrap/Backform/jQuery components were used.
>>>>>> - The new code uses JSS instead of CSS since material ui and most
>>>>>> modern React libraries also use JSS. In future, this will allow us to
>>>>>> change the theme in real-time without refresh.
>>>>>> - 90% code covered by 80-85 new jasmine test cases.
>>>>>> - Server group node UI Schema migration to new, with schema test
>>>>>> cases.
>>>>>> - Server node UI Schema migration to new, with schema test cases.
>>>>>> - Database node UI Schema migration to new, with schema test cases.
>>>>>> - Few other UI changes.
>>>>>>
>>>>>
>>>>> Nice!
>>>>>
>>>>>
>>>>>>
>>>>>> PS: Until all the nodes are migrated, this will not go in the main
>>>>>> branch.
>>>>>>
>>>>>
>>>>> Yeah, how are we going to manage this? I agree with building it out in
>>>>> a branch until we have full coverage of the dialogues, but I'm concerned
>>>>> that it'll become a merge nightmare. Though, I guess we aren't touching the
>>>>> dialogues much for other things right now, so maybe not.
>>>>>
>>>> We'll right now work only on the dialogs. So merging should be
>>>> manageable.
>>>> BTW, the patch can be merged in the main branch as well. It is backward
>>>> compatible, and it will work fine. Only the UI components would look
>>>> slightly different from the non-migrated dialogs.
>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: https://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>>> <http://edbpostgres.com;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

view thread (7+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs
  In-Reply-To: <CANxoLDeKHvKmFvfywm2xxfgu7k0kHKV7Ba8M5AGTR71rf9r7pA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox