public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to an invisible label where a visible label cannot be used
Date: Wed, 4 Dec 2019 18:19:40 +0530
Message-ID: <CANxoLDeOaJWOu91=ngskhNiWsheja=ZgzNeA7Lw9B=n3GWhf+w@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mg+_gPEp0cz=PAnZJCOSBYrd4S-wu9u-+q9UFdo0zN6w@mail.gmail.com>
References: <CAM9w-_kbux3pL4JT=8XA20BLk6=L3qXWNP8d4EraeA9mdAA3vQ@mail.gmail.com>
<CANxoLDdeVj8vVPOjEFuTSMO0tw1m3zdJzTqfH2fhcU3d_bUXKA@mail.gmail.com>
<CAM9w-_mg+_gPEp0cz=PAnZJCOSBYrd4S-wu9u-+q9UFdo0zN6w@mail.gmail.com>
Thanks, patch applied.
On Wed, Dec 4, 2019 at 3:00 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the feature tests which were failing after
> the commit. The reason being, the span elements which was used to show
> properties tab data is changed to input now as per accessibility
> requirements. Also, there is no way now to check XSS of input because the
> input tags returns the original value on extracting the value attribute and
> not the escaped value. Previously, the value was HTML element under the
> span tag.
> Not to worry, input is escaped and is XSS free, handled in underscore
> templates.
>
> On Tue, Dec 3, 2019 at 12:48 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Dec 3, 2019 at 11:39 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to add label and aria-label wherever applicable.
>>> The patch also fixes few other accessibility related errors raised by
>>> "WAVE" extension of Chrome.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to an invisible label where a visible label cannot be used
In-Reply-To: <CANxoLDeOaJWOu91=ngskhNiWsheja=ZgzNeA7Lw9B=n3GWhf+w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox