public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0
Date: Wed, 13 Jun 2018 18:20:22 +0530
Message-ID: <CANxoLDePuSy9xkj3uQXjvjTTbFO_g=eFac6_VJGktcK6dfbz8g@mail.gmail.com> (raw)
Hi Hackers,
Attached is the patch to fix RM #3374 Code auto complete is broken in
pgadmin4 V 3.0.
I'll create a new RM to merge latest *pgcli
<https://github.com/dbcli/pgcli>* code used for SQL Auto complete in
pgAdmin4.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachments:
[application/octet-stream] RM_3374.patch (568B, 3-RM_3374.patch)
download | inline diff:
diff --git a/web/pgadmin/utils/sqlautocomplete/parseutils.py b/web/pgadmin/utils/sqlautocomplete/parseutils.py
index 29b6ac8..b08a392 100644
--- a/web/pgadmin/utils/sqlautocomplete/parseutils.py
+++ b/web/pgadmin/utils/sqlautocomplete/parseutils.py
@@ -73,7 +73,7 @@ TableReference = namedtuple(
# This code is borrowed from sqlparse example script.
# <url>
def is_subselect(parsed):
- if not parsed.is_group():
+ if not parsed.is_group:
return False
sql_type = ('SELECT', 'INSERT', 'UPDATE', 'CREATE', 'DELETE')
for item in parsed.tokens:
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0
In-Reply-To: <CANxoLDePuSy9xkj3uQXjvjTTbFO_g=eFac6_VJGktcK6dfbz8g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox