public inbox for [email protected]  

help / color / mirror / Atom feed

[pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0
2+ messages / 2 participants
[nested] [flat]

* [pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0
@ 2018-06-13 12:50  Akshay Joshi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Akshay Joshi @ 2018-06-13 12:50 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix RM #3374 Code auto complete is broken in
pgadmin4 V 3.0.
I'll create a new RM to merge latest *pgcli
<https://github.com/dbcli/pgcli>* code used for SQL Auto complete in
pgAdmin4.

-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Attachments:

  [application/octet-stream] RM_3374.patch (568B, 3-RM_3374.patch)
  download | inline diff:
diff --git a/web/pgadmin/utils/sqlautocomplete/parseutils.py b/web/pgadmin/utils/sqlautocomplete/parseutils.py
index 29b6ac8..b08a392 100644
--- a/web/pgadmin/utils/sqlautocomplete/parseutils.py
+++ b/web/pgadmin/utils/sqlautocomplete/parseutils.py
@@ -73,7 +73,7 @@ TableReference = namedtuple(
 # This code is borrowed from sqlparse example script.
 # <url>
 def is_subselect(parsed):
-    if not parsed.is_group():
+    if not parsed.is_group:
         return False
     sql_type = ('SELECT', 'INSERT', 'UPDATE', 'CREATE', 'DELETE')
     for item in parsed.tokens:


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0
@ 2018-06-13 14:53  Dave Page <[email protected]>
  parent: Akshay Joshi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2018-06-13 14:53 UTC (permalink / raw)
  To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Wed, Jun 13, 2018 at 1:50 PM, Akshay Joshi <[email protected]
> wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #3374 Code auto complete is broken in
> pgadmin4 V 3.0.
> I'll create a new RM to merge latest *pgcli
> <https://github.com/dbcli/pgcli>* code used for SQL Auto complete in
> pgAdmin4.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2018-06-13 14:53 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-06-13 12:50 [pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0 Akshay Joshi <[email protected]>
2018-06-13 14:53 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox