public inbox for [email protected]  
help / color / mirror / Atom feed
[patch][pgAdmin] RM6802 Unable to edit trigger for advanced servers
2+ messages / 2 participants
[nested] [flat]

* [patch][pgAdmin] RM6802 Unable to edit trigger for advanced servers
@ 2021-10-14 12:35  Rahul Shirsat <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Rahul Shirsat @ 2021-10-14 12:35 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Please find the attached patch which resolves the issue of editing triggers
for advanced servers.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


Attachments:

  [application/octet-stream] RM6802.patch (2.2K, 3-RM6802.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/utils.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/utils.py
index 9b1a227b6..3c2cf2ffd 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/utils.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/triggers/utils.py
@@ -185,6 +185,12 @@ def get_sql(conn, **kwargs):
 
         old_data = trigger_definition(old_data)
 
+        if 'lanname' in old_data and old_data['lanname'] == 'edbspl':
+            data['lanname'] = old_data['lanname']
+        if ('tfunction' in old_data and
+                old_data['tfunction'] == 'Inline EDB-SPL'):
+            data['tfunction'] = old_data['tfunction']
+
         sql = render_template(
             "/".join([template_path, 'update.sql']),
             data=data, o_data=old_data, conn=conn
diff --git a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
index 2c8534553..2fb335047 100644
--- a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
+++ b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
@@ -80,6 +80,8 @@ $color-editor-bracket: #d6aaaa;
 $color-editor-operator: #d6aaaa;
 $color-editor-foldmarker: #0000FF !default;
 $color-editor-activeline: #323e43 !default;
+$color-editor-activeline-light: $color-editor-activeline;
+$color-editor-activeline-border-color: none;
 
 $explain-sev-2-bg: #ded17e;
 $explain-sev-3-bg: #824d18;
diff --git a/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss b/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
index cd6462df4..2f6c1f9d5 100644
--- a/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
+++ b/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
@@ -97,6 +97,8 @@ $color-editor-bracket: #D6AAAA;
 $color-editor-operator: $color-fg;
 $color-editor-foldmarker: #FFFFFF;
 $color-editor-activeline: #063057;
+$color-editor-activeline-light: $color-editor-activeline;
+$color-editor-activeline-border-color: none;
 
 $active-color: $color-fg;
 $active-border: 3px solid $color-primary;


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [patch][pgAdmin] RM6802 Unable to edit trigger for advanced servers
@ 2021-10-16 07:29  Akshay Joshi <[email protected]>
  parent: Rahul Shirsat <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2021-10-16 07:29 UTC (permalink / raw)
  To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers

Thanks, the patch applied.

On Thu, Oct 14, 2021 at 6:05 PM Rahul Shirsat <
[email protected]> wrote:

> Hi Hackers,
>
> Please find the attached patch which resolves the issue of editing
> triggers for advanced servers.
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2021-10-16 07:29 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-10-14 12:35 [patch][pgAdmin] RM6802 Unable to edit trigger for advanced servers Rahul Shirsat <[email protected]>
2021-10-16 07:29 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox