public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: navnath gadakh <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RE-SQL tests patch for packages node
Date: Mon, 2 Sep 2019 17:43:21 +0530
Message-ID: <CANxoLDeZyorRVWAXuk9+qKxwxrXMN-UNhPzbM9N6R0C16=oO-w@mail.gmail.com> (raw)
In-Reply-To: <CAOAJCYpski3tUyjURuXO0DDk5fOndaBGOPGCenw59GRWA=bzOw@mail.gmail.com>
References: <CAOAJCYqQiGq55wth0Ptu9bVxvsRqs4xy3hMSmQ1zZZ3JvEGkSg@mail.gmail.com>
<CANxoLDc8W1UrhVvfGz+PZ9BX6vqz2AnZvv3yOse0_TYx=796YQ@mail.gmail.com>
<CA+OCxowjiK5twuNVCnuXiBZmg8XZNCtdmBULgCjJwcJCfpS6VQ@mail.gmail.com>
<CAOAJCYookN4C1LDAG_Mvt1fdMp1ZrLMyPEnBoQq9arB-cuzO9w@mail.gmail.com>
<CA+OCxowO-q9TF48N9VjYQeG1zHTOxZc-t6m5U4TeRuO9B-XpBQ@mail.gmail.com>
<CAOAJCYpski3tUyjURuXO0DDk5fOndaBGOPGCenw59GRWA=bzOw@mail.gmail.com>
Hi Navnath
Following are the review comments:
- GRANT statement is not visible in RE-SQL for create and alter both.
(May be bug in Packages please fix that too)
- Delete packages is missing in json file.
- Add test cases to revoke privileges(delete all the privileges). Check
Languages node for reference.
On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh <
[email protected]> wrote:
> Hi Dave,
> Please find the patch for M-SQL test cases for *Packages* module.
>
> Thanks!
>
> On Fri, Jul 12, 2019 at 4:02 PM Dave Page <[email protected]>
> wrote:
>
>> Thanks, applied.
>>
>> On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find the modified patch for packages as test cases were
>>> failing on some servers.
>>> Thanks!
>>>
>>>
>>> On Thu, Jul 11, 2019 at 1:53 PM Dave Page <[email protected]>
>>> wrote:
>>>
>>>> Thanks, applied.
>>>>
>>>> On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Navnath
>>>>>
>>>>> I have tested the patch and it is not working for EPAS 9.4, 9.5 and
>>>>> 9.6. Attached is the modified patch which fix the issue.
>>>>> Please work on child node (functions, procedure and variables) of
>>>>> Packages on top of modified patch.
>>>>>
>>>>> On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> I have attached the patch for RE-SQL test cases for *Packages*
>>>>>> node.
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>> --
>>>>>> *Regards,*
>>>>>> *Navnath Gadakh*
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> VP, Chief Architect, Tools & Installers
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>
>>>
>>> --
>>> *Regards,*
>>> *Navnath Gadakh*
>>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
> --
> *Regards,*
> *Navnath Gadakh*
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: RE-SQL tests patch for packages node
In-Reply-To: <CANxoLDeZyorRVWAXuk9+qKxwxrXMN-UNhPzbM9N6R0C16=oO-w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox